Commit c35953b
Waleed Latif
test(sidebar): assert the keyboard cursor on a row that isn't selected
Review round 1: the keyboard-positive assertions landed on the current
workspace, which carries its own `isActive` fill, so they held whether or
not the cursor was painted — the tests could not have caught deleting
keyboard-cursor rendering.
Navigate with ArrowUp instead, wrapping from the seeded first row to the
last, and assert on that row. Verified both directions now: removing the
modality gate reddens three tests, removing keyboard painting reddens two.1 parent fbc6fa1 commit c35953b
1 file changed
Lines changed: 11 additions & 7 deletions
File tree
- apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header
Lines changed: 11 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | | - | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
170 | 172 | | |
171 | 173 | | |
172 | 174 | | |
173 | 175 | | |
174 | 176 | | |
175 | 177 | | |
176 | 178 | | |
177 | | - | |
| 179 | + | |
178 | 180 | | |
179 | | - | |
| 181 | + | |
180 | 182 | | |
181 | 183 | | |
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
185 | | - | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
186 | 190 | | |
187 | | - | |
| 191 | + | |
188 | 192 | | |
189 | 193 | | |
0 commit comments