fix(chat): copy workspace resources as portable links

Author: j15z

apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.tsx

@@ -8,6 +8,7 @@ import {
   ChipModalField,
   ChipModalFooter,
   ChipModalHeader,
+  type ClipboardContent,
   cn,
   Duplicate,
   Split,
@@ -32,7 +33,7 @@ interface MessageActionsProps {
   content: string
   getCopyContent?: () => string
   hasCopyContent?: boolean
-  prepareContentForCopy?: (content: string) => string
+  prepareContentForCopy?: (content: string) => ClipboardContent
   userQuery?: string
   requestId?: string
   messageId?: string
@@ -70,7 +71,7 @@ export const MessageActions = memo(function MessageActions({
     const contentToCopy = getCopyContent?.() ?? content
     if (!contentToCopy) return
     const markdown = prepareContentForCopy?.(contentToCopy) ?? contentToCopy
-    if (!markdown) return
+    if (typeof markdown === 'string' && !markdown) return
     void copyMessage(markdown)
   }
 

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/extensions.ts

@@ -11,12 +11,12 @@ import {
 } from '@tiptap/extension-table'
 import { Markdown } from '@tiptap/markdown'
 import StarterKit from '@tiptap/starter-kit'
+import { SIM_LINK_SCHEME } from '@/lib/copilot/sim-link'
 import { MarkdownCodeBlock } from './code-block-schema'
 import { Highlight } from './highlight'
 import { MarkdownImage } from './image-schema'
 import { MarkdownLinkInputRule } from './link-input-rule'
 import { MarkdownMention } from './mention/mention-node'
-import { SIM_LINK_SCHEME } from './mention/sim-link'
 import {
   FootnoteDef,
   FootnoteRef,

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/index.ts

@@ -1,7 +1,8 @@
+export { SIM_LINK_SCHEME, toSimHref } from '@/lib/copilot/sim-link'
 export { MENTION_PLUGIN_KEY, Mention, type MentionStorage } from './mention'
 export { MentionChip } from './mention-chip'
 export { MarkdownMention } from './mention-node'
-export { SIM_LINK_SCHEME, simLinkPath, toSimHref } from './sim-link'
+export { simLinkPath } from './sim-link'
 export type { MentionItem, MentionKind } from './types'
 export { useEditorMentions } from './use-editor-mentions'
 export { useMarkdownMentions } from './use-markdown-mentions'

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/mention-node.test.ts

@@ -44,6 +44,14 @@ describe('mention node round-trip', () => {
     expect(serializeMarkdownBody(input).trim()).toBe(input)
   })
 
+  it('round-trips a file reference containing whitespace and a closing parenthesis', () => {
+    const input = '[Q1 plan](sim:file/files/Q1%20plan%29.md)'
+    const doc = parseMarkdownToDoc(input)
+    const mention = findMention(doc)
+    expect(mention?.attrs).toEqual({ kind: 'file', id: 'files/Q1 plan).md', label: 'Q1 plan' })
+    expect(serializeMarkdownBody(input).trim()).toBe(input)
+  })
+
   it('leaves a normal http link as a link, not a mention', () => {
     const doc = parseMarkdownToDoc('[Sim](https://sim.ai)')
     expect(findMention(doc)).toBeNull()

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/mention-node.ts

@@ -1,6 +1,6 @@
 import type { JSONContent, MarkdownToken } from '@tiptap/core'
 import { InputRule, Node } from '@tiptap/core'
-import { toSimHref } from './sim-link'
+import { fromSimHrefId, fromSimMarkdownLabel, toSimMarkdownLink } from '@/lib/copilot/sim-link'
 import type { MentionKind } from './types'
 
 export interface MentionAttrs {
@@ -16,16 +16,6 @@ export interface MentionAttrs {
  */
 const MENTION_MD_RE = /^\[((?:\\.|[^\]\\])+)\]\(sim:([a-z_]+)\/([^)\s]+)\)/
 
-/** Escape `\`, `[`, `]` in a mention label so brackets in entity names can't break the link syntax. */
-function escapeLabel(label: string): string {
-  return label.replace(/[\\[\]]/g, '\\$&')
-}
-
-/** Inverse of {@link escapeLabel}, applied when parsing a mention back from markdown. */
-function unescapeLabel(label: string): string {
-  return label.replace(/\\([\\[\]])/g, '$1')
-}
-
 /** Custom fields the mention tokenizer hangs on the marked token (all optional, like the image token). */
 interface MentionTokenFields {
   label?: string
@@ -91,17 +81,21 @@ export const MarkdownMention = Node.create({
     const { kind, id, label } = token as MentionTokenFields
     return {
       type: 'mention',
-      attrs: { kind: kind ?? '', id: id ?? '', label: unescapeLabel(label ?? '') },
+      attrs: {
+        kind: kind ?? '',
+        id: fromSimHrefId(id ?? ''),
+        label: fromSimMarkdownLabel(label ?? ''),
+      },
     }
   },
   renderMarkdown: (node: JSONContent): string => {
     const { kind, id, label } = (node.attrs ?? {}) as MentionAttrs
-    return `[${escapeLabel(label)}](${toSimHref(kind, id)})`
+    return toSimMarkdownLink(kind, id, label)
   },
 
   renderText: ({ node }) => {
     const { kind, id, label } = node.attrs as MentionAttrs
-    return `[${escapeLabel(label)}](${toSimHref(kind, id)})`
+    return toSimMarkdownLink(kind, id, label)
   },
 
   /**
@@ -123,7 +117,11 @@ export const MarkdownMention = Node.create({
           state.tr.replaceWith(
             range.from,
             range.to,
-            type.create({ kind, id, label: unescapeLabel(rawLabel ?? '') })
+            type.create({
+              kind,
+              id: fromSimHrefId(id),
+              label: fromSimMarkdownLabel(rawLabel ?? ''),
+            })
           )
         },
       }),

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/sim-link.test.ts

@@ -1,6 +1,21 @@
 import { describe, expect, it } from 'vitest'
+import { fromSimHrefId, toSimHref } from '@/lib/copilot/sim-link'
 import { simLinkPath } from './sim-link'
 
+describe('sim link id codec', () => {
+  it('round-trips identifiers containing link delimiters', () => {
+    const id = 'files/Q1 plan).md'
+    const href = toSimHref('file', id)
+
+    expect(href).toBe('sim:file/files/Q1%20plan%29.md')
+    expect(fromSimHrefId(href.slice('sim:file/'.length))).toBe(id)
+  })
+
+  it('leaves malformed percent encoding intact', () => {
+    expect(fromSimHrefId('file%2')).toBe('file%2')
+  })
+})
+
 describe('simLinkPath', () => {
   const ws = 'ws1'
 

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/sim-link.ts

@@ -1,14 +1,3 @@
-/**
- * The link scheme for `@`-mention links — `[label](sim:<kind>/<id>)`. Matches the chat composer's
- * portable chip format (`chip-clipboard-codec.ts`), so a mention authored here is parseable there.
- */
-export const SIM_LINK_SCHEME = 'sim'
-
-/** Builds the link target for a mention of `kind`/`id`. */
-export function toSimHref(kind: string, id: string): string {
-  return `${SIM_LINK_SCHEME}:${kind}/${id}`
-}
-
 /**
  * Resolves the in-app route for a clicked `sim:` mention, or `null` when the kind has no navigable
  * destination. Each path matches the entity's real route: files open the file detail view,

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/chat-content.tsx

@@ -15,6 +15,10 @@ import { Checkbox, CopyCodeButton, cn, languages, highlight as prismHighlight }
 import { decodeVfsSegmentSafe } from '@/lib/copilot/vfs/path-utils'
 import { extractTextContent } from '@/lib/core/utils/react-node-text'
 import { ContextMentionIcon } from '@/app/workspace/[workspaceId]/home/components/context-mention-icon'
+import {
+  appendInlineReferenceMarkdown,
+  workspaceResourceReferenceMarkdown,
+} from '@/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/workspace-resource-markdown'
 import {
   type ContentSegment,
   type CredentialSubmissionPayload,
@@ -95,47 +99,6 @@ const ANIMATION_DRAIN_MS = 300
  */
 const FADE_MAX_REVEALED_CHARS = 6000
 
-function startsInlineWord(value: string): boolean {
-  return /^[A-Za-z0-9_(]/.test(value)
-}
-
-function endsInlineWord(value: string): boolean {
-  return /[A-Za-z0-9_)]$/.test(value)
-}
-
-function nextInlineSegmentLabel(segment?: ContentSegment): string {
-  if (!segment) return ''
-  // Thinking segments are never rendered, so they contribute no following text.
-  if (segment.type === 'text') return segment.content
-  if (segment.type === 'workspace_resource') return segment.data.title || segment.data.id || ''
-  return ''
-}
-
-function appendInlineReferenceMarkdown(
-  currentMarkdown: string,
-  referenceMarkdown: string,
-  nextSegment?: ContentSegment
-): string {
-  let nextMarkdown = currentMarkdown
-  if (currentMarkdown && endsInlineWord(currentMarkdown) && !/\s$/.test(currentMarkdown)) {
-    nextMarkdown += ' '
-  }
-
-  nextMarkdown += referenceMarkdown
-
-  const followingText = nextInlineSegmentLabel(nextSegment)
-  if (
-    followingText &&
-    startsInlineWord(followingText) &&
-    !/^\s/.test(followingText) &&
-    !/\s$/.test(nextMarkdown)
-  ) {
-    nextMarkdown += ' '
-  }
-
-  return nextMarkdown
-}
-
 type TdProps = ComponentPropsWithoutRef<'td'>
 type ThProps = ComponentPropsWithoutRef<'th'>
 
@@ -586,14 +549,9 @@ function ChatContentInner({
     const s = parsed.segments[i]
     const nextSegment = parsed.segments[i + 1]
     if (s.type === 'workspace_resource') {
-      // Files are addressed by their encoded VFS path (copied verbatim from the tag);
-      // workflows/tables/KBs by id. The angle-bracket link destination keeps the path
-      // intact through markdown parsing (tolerates parens) without re-encoding it.
-      const ref = s.data.type === 'file' ? (s.data.path ?? s.data.id ?? '') : (s.data.id ?? '')
-      const label = s.data.title || ref
       pendingMarkdown = appendInlineReferenceMarkdown(
         pendingMarkdown,
-        `[${label}](<#wsres-${s.data.type}-${ref}>)`,
+        workspaceResourceReferenceMarkdown(s.data),
         nextSegment
       )
     } else if (s.type === 'thinking') {

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/workspace-resource-markdown.ts

@@ -0,0 +1,54 @@
+import type {
+  ContentSegment,
+  WorkspaceResourceTagData,
+} from '@/app/workspace/[workspaceId]/home/components/message-content/components/special-tags'
+
+function startsInlineWord(value: string): boolean {
+  return /^[A-Za-z0-9_(]/.test(value)
+}
+
+function endsInlineWord(value: string): boolean {
+  return /[A-Za-z0-9_)]$/.test(value)
+}
+
+export function workspaceResourceLabel(data: WorkspaceResourceTagData): string {
+  if (data.title) return data.title
+  return data.type === 'file' ? (data.path ?? data.id ?? '') : (data.id ?? '')
+}
+
+function nextInlineSegmentLabel(segment?: ContentSegment): string {
+  if (!segment) return ''
+  if (segment.type === 'text') return segment.content
+  if (segment.type === 'workspace_resource') return segment.data.title || segment.data.id || ''
+  return ''
+}
+
+export function workspaceResourceReferenceMarkdown(data: WorkspaceResourceTagData): string {
+  const ref = data.type === 'file' ? (data.path ?? data.id ?? '') : (data.id ?? '')
+  return `[${workspaceResourceLabel(data)}](<#wsres-${data.type}-${ref}>)`
+}
+
+export function appendInlineReferenceMarkdown(
+  currentMarkdown: string,
+  referenceMarkdown: string,
+  nextSegment?: ContentSegment
+): string {
+  let nextMarkdown = currentMarkdown
+  if (currentMarkdown && endsInlineWord(currentMarkdown) && !/\s$/.test(currentMarkdown)) {
+    nextMarkdown += ' '
+  }
+
+  nextMarkdown += referenceMarkdown
+
+  const followingText = nextInlineSegmentLabel(nextSegment)
+  if (
+    followingText &&
+    startsInlineWord(followingText) &&
+    !/^\s/.test(followingText) &&
+    !/\s$/.test(nextMarkdown)
+  ) {
+    nextMarkdown += ' '
+  }
+
+  return nextMarkdown
+}