Skip to content

Commit 1a1cb75

Browse files
fix(slack): retain custom app credential constraints
1 parent 65d4565 commit 1a1cb75

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
ALTER TABLE "slack_app" ALTER COLUMN "client_id" DROP NOT NULL;--> statement-breakpoint
22
ALTER TABLE "slack_app" ALTER COLUMN "encrypted_client_secret" DROP NOT NULL;--> statement-breakpoint
3-
ALTER TABLE "slack_app" ALTER COLUMN "encrypted_signing_secret" DROP NOT NULL;
3+
ALTER TABLE "slack_app" ALTER COLUMN "encrypted_signing_secret" DROP NOT NULL;--> statement-breakpoint
4+
ALTER TABLE "slack_app" ADD CONSTRAINT "slack_app_custom_credentials_check" CHECK ("slack_app"."kind" = 'shared' OR ("slack_app"."client_id" IS NOT NULL AND "slack_app"."encrypted_client_secret" IS NOT NULL AND "slack_app"."encrypted_signing_secret" IS NOT NULL)) NOT VALID;

packages/db/migrations/meta/0340_snapshot.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"id": "50aacfdd-df65-4309-8f8b-3b94bbe4a92c",
2+
"id": "ae1f15e2-2725-434a-a1ac-9ea8a857868d",
33
"prevId": "1bdee29d-c55a-4de9-a0a3-03a6c6aa68aa",
44
"version": "7",
55
"dialect": "postgresql",
@@ -17053,6 +17053,10 @@
1705317053
"slack_app_owner_check": {
1705417054
"name": "slack_app_owner_check",
1705517055
"value": "(\"slack_app\".\"kind\" = 'custom' AND \"slack_app\".\"organization_id\" IS NOT NULL) OR (\"slack_app\".\"kind\" = 'shared' AND \"slack_app\".\"organization_id\" IS NULL)"
17056+
},
17057+
"slack_app_custom_credentials_check": {
17058+
"name": "slack_app_custom_credentials_check",
17059+
"value": "\"slack_app\".\"kind\" = 'shared' OR (\"slack_app\".\"client_id\" IS NOT NULL AND \"slack_app\".\"encrypted_client_secret\" IS NOT NULL AND \"slack_app\".\"encrypted_signing_secret\" IS NOT NULL)"
1705617060
}
1705717061
},
1705817062
"isRLSEnabled": false

packages/db/migrations/meta/_journal.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2378,7 +2378,7 @@
23782378
{
23792379
"idx": 340,
23802380
"version": "7",
2381-
"when": 1789149621029,
2381+
"when": 1789150173739,
23822382
"tag": "0340_slack_shared_app_env",
23832383
"breakpoints": true
23842384
}

packages/db/schema.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4979,6 +4979,10 @@ export const slackApp = pgTable(
49794979
'slack_app_owner_check',
49804980
sql`(${table.kind} = 'custom' AND ${table.organizationId} IS NOT NULL) OR (${table.kind} = 'shared' AND ${table.organizationId} IS NULL)`
49814981
),
4982+
customCredentialsCheck: check(
4983+
'slack_app_custom_credentials_check',
4984+
sql`${table.kind} = 'shared' OR (${table.clientId} IS NOT NULL AND ${table.encryptedClientSecret} IS NOT NULL AND ${table.encryptedSigningSecret} IS NOT NULL)`
4985+
),
49824986
})
49834987
)
49844988

0 commit comments

Comments
 (0)