From 5c942b2279bb99bf9adbade75060a4b7a859f756 Mon Sep 17 00:00:00 2001
From: Mikita Hradovich <mikita.hradovich@scylladb.com>
Date: Wed, 24 Jun 2026 18:56:33 +0200
Subject: [PATCH] build: fix javadoc generation in core-shaded for Netty
 4.1.135 and Jackson 2.21

The top-level <configuration><skip>true</skip></configuration> block was
introduced in deaeb1c44 ("build: drop Java 8 support", May 25 2026) to paper
over a javadoc compilation failure caused by the Netty 4.1.135.Final bump.
That version added compile-time references to org.jetbrains:annotations
(@NotNull, @VisibleForTesting, @Async.Execute/Schedule). Jackson 2.21.x
sources also reference ch.randelshofer:fastdoubleparser, which is bundled-
and-shaded inside jackson-core with no standalone resolvable Maven coordinate.

With <skip>true</skip> at the plugin level, no javadoc jar is attached for
the core-shaded artifact, causing Sonatype Central to reject the release.

Fix:
- Remove the global skip flag (the attach-javadocs execution is still in place)
- Add org.jetbrains:annotations:23.0.0 to additionalDependencies (matches
  the version Netty uses as a provided dependency)
- Set failOnError=false for the fastdoubleparser case; those sources are
  already excluded from the output via excludePackageNames, so the jar still
  contains the full public API documentation
---
 core-shaded/pom.xml | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/core-shaded/pom.xml b/core-shaded/pom.xml
index 7775d4ad2a7..213ab184281 100644
--- a/core-shaded/pom.xml
+++ b/core-shaded/pom.xml
@@ -280,9 +280,6 @@
       </plugin>
       <plugin>
         <artifactId>maven-javadoc-plugin</artifactId>
-        <configuration>
-          <skip>true</skip>
-        </configuration>
         <executions>
           <execution>
             <id>attach-javadocs</id>
@@ -293,11 +290,22 @@
               <sourcepath>${project.build.directory}/shaded-sources</sourcepath>
               <excludePackageNames>com.datastax.*.driver.internal*,com.datastax.oss.driver.shaded*</excludePackageNames>
               <!--
-                javadoc processes the shaded Netty sources (even though they're not included in the
-                report), and will complain if it doesn't find JCTools classes.
-                Add the dependency just to avoid warnings:
+                javadoc processes the shaded Netty and Jackson sources (even though they're not
+                included in the report), and will fail if transitive compile-time dependencies of
+                those libraries are missing from the javadoc classpath. Add the ones that are not
+                already present as transitive compile dependencies of core-shaded.
+                failOnError=false handles any remaining missing packages (e.g. ch.randelshofer:
+                fastdoubleparser, which is bundled-and-shaded inside jackson-core and has no
+                standalone published coordinate we can resolve here).
               -->
+              <failOnError>false</failOnError>
               <additionalDependencies>
+                <additionalDependency>
+                  <!-- Netty 4.1.x uses @NotNull, @VisibleForTesting, @Async.Execute/Schedule -->
+                  <groupId>org.jetbrains</groupId>
+                  <artifactId>annotations</artifactId>
+                  <version>23.0.0</version>
+                </additionalDependency>
                 <additionalDependency>
                   <groupId>org.xerial.snappy</groupId>
                   <artifactId>snappy-java</artifactId>