Skip to content

Commit 1c80358

Browse files
authored
remove default image caption and remove default grid border (#670)
* remove default image caption and remove default grid border * ladz load editor assets
1 parent 01ce0f2 commit 1c80358

9 files changed

Lines changed: 36 additions & 11 deletions

File tree

app/controllers/resources_controller.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@ def new
3535
def edit
3636
@resource = Resource.find(resource_id_param).decorate
3737
set_form_variables
38+
39+
if turbo_frame_request?
40+
render :rich_text_assets
41+
else
42+
render :edit
43+
end
3844
end
3945

4046
def show

app/controllers/workshops_controller.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,12 @@ def new
8080
def edit
8181
@workshop = Workshop.find(params[:id])
8282
set_form_variables
83+
84+
if turbo_frame_request?
85+
render :rich_text_assets
86+
else
87+
render :edit
88+
end
8389
end
8490

8591
def show

app/frontend/javascript/rhino/grid/gridCell.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export const GridCell = Node.create({
1919
default: 1,
2020
},
2121
hasBorder: {
22-
default: true,
22+
default: false,
2323
},
2424
};
2525
},

app/views/active_storage/blobs/_blob.html.erb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
<figcaption class="attachment__caption text-center">
77
<% if caption = blob.try(:caption) %>
88
<%= caption %>
9-
<% else %>
10-
<span class="attachment__name"><%= blob.filename %></span>
11-
<span class="attachment__size"><%= number_to_human_size blob.byte_size %></span>
129
<% end %>
1310
</figcaption>
1411
</figure>

app/views/resources/edit.html.erb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1-
<% resource = @resource.respond_to?(:object) ? @resource.object : @resource %>
2-
31
<div class="min-h-screen py-8">
42
<div class="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8">
53
<div class="max-w-5xl mx-auto <%= DomainTheme.bg_class_for(:resources) %> border border-gray-200 rounded-xl shadow-lg hover:shadow-xl transition-shadow duration-200 p-6">
64
<div class="flex items-center justify-between mb-3">
7-
<h1 class="text-2xl font-semibold text-gray-900">Edit <%= resource.class.model_name.human %></h1>
5+
<h1 class="text-2xl font-semibold text-gray-900">Edit <%= @resource.class.model_name.human %></h1>
86

97
<div class="text-right text-end">
10-
<%= link_to "View", resource_path(resource), class: "btn btn-secondary-outline" %>
8+
<%= link_to "View", resource_path(@resource), class: "btn btn-secondary-outline" %>
119
</div>
1210
</div>
1311

1412
<div class="space-y-6">
1513
<div class="mt-4 bg-white rounded p-3"><%= render "form" %></div>
16-
<%= render 'rich_text_assets/form', owner: resource %>
14+
15+
<%= turbo_frame_tag "editor_assets_lazy", src: edit_resource_path(@resource) do %>
16+
<span>Loading..</span>
17+
<% end %>
1718
</div>
1819
</div>
1920
</div>
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<%= turbo_frame_tag "editor_assets_lazy" do %>
2+
<%= render 'rich_text_assets/form', owner: @resource %>
3+
<% end %>

app/views/rich_text_assets/_form.html.erb

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,14 @@
4141
</div>
4242

4343
<div>
44-
<%= f.submit "Upload Asset", class: "w-full bg-indigo-600 text-white font-semibold py-2 px-4 rounded-lg hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-indigo-300 transition" %>
44+
<%= f.submit "Upload Asset",
45+
class: "w-full bg-indigo-600 text-white font-semibold py-2 px-4 rounded-lg
46+
hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-indigo-300
47+
transition
48+
disabled:bg-indigo-400 disabled:cursor-not-allowed disabled:opacity-70",
49+
data: {
50+
disable_with: "Uploading..."
51+
} %>
4552
</div>
4653
<% end %>
4754
<% end %>

app/views/workshops/edit.html.erb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
<div class="mt-4"><%= render "form", workshop: @workshop %></div>
1313
<div class="mt-4"><%# render "form_old", workshop: @workshop %></div>
1414

15-
<%= render 'rich_text_assets/form', owner: @workshop %>
15+
<%= turbo_frame_tag "editor_assets_lazy", src: edit_workshop_path(@workshop) do %>
16+
<span>Loading..</span>
17+
<% end %>
1618
</div>
1719
</div>
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<%= turbo_frame_tag "editor_assets_lazy" do %>
2+
<%= render 'rich_text_assets/form', owner: @workshop %>
3+
<% end %>

0 commit comments

Comments
 (0)