Skip to content

Commit 1343920

Browse files
author
SergeyPirogov
committed
fix npe for response body
1 parent bdb1d38 commit 1343920

3 files changed

Lines changed: 15 additions & 9 deletions

File tree

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plugins {
55

66
archivesBaseName = 'reqover-java'
77
group='io.reqover'
8-
version='0.2.4'
8+
version='0.2.5'
99

1010
repositories {
1111
mavenCentral()

src/main/java/io/reqover/rest/assured/CoverageFilter.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,12 @@ protected CoverageInfo collectCoverageInfo(FilterableRequestSpecification reques
3939
queryParameters.addAll(requestParameters);
4040

4141
Object body = requestSpec.getBody();
42-
43-
Object responseBody = response.getBody().as(Object.class);
42+
Object responseBody = null;
43+
try {
44+
responseBody = response.getBody().as(Object.class);
45+
} catch (Exception e) {
46+
//System.err.println("Error parsing response body "+e);
47+
}
4448

4549
CoverageInfo coverageInfo = new CoverageInfo();
4650
coverageInfo.setUri(uri);
@@ -50,7 +54,9 @@ protected CoverageInfo collectCoverageInfo(FilterableRequestSpecification reques
5054
coverageInfo.setMethod(method);
5155
coverageInfo.setParameters(queryParameters);
5256
coverageInfo.setBody(body);
53-
coverageInfo.setResponse(Map.of("statusCode", statusCode, "body", responseBody));
57+
if (responseBody != null) {
58+
coverageInfo.setResponse(Map.of("statusCode", statusCode, "body", responseBody));
59+
}
5460

5561
return coverageInfo;
5662
}

src/test/java/io/reqover/test/TestCoverage.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ public class TestCoverage {
2323

2424
// private static final String REQOVER_RESULTS = "reqover-results";
2525
// private final static Reqover reqover = new Reqover(REQOVER_SERVER_URL, "o5moiyopdmjs");
26-
// private final SwaggerCoverage swaggerCoverage = new SwaggerCoverage(REQOVER_RESULTS);
26+
private final SwaggerCoverage swaggerCoverage = new SwaggerCoverage();
2727

2828
@BeforeAll
2929
public static void setUp() {
30-
// RestAssured.baseURI = "https://petstore.swagger.io";
31-
RestAssured.baseURI = "http://localhost:8080";
30+
RestAssured.baseURI = "https://petstore.swagger.io";
31+
// RestAssured.baseURI = "http://localhost:8080";
3232
RestAssured.basePath = "/v2";
3333
// RestAssured.basePath = "/api/v3";
3434
}
@@ -44,8 +44,8 @@ public static void setUp() {
4444

4545
private RequestSpecification setup() {
4646
return RestAssured.given()
47-
.filter(new RequestLoggingFilter());
48-
// .filter(swaggerCoverage);
47+
.filter(new RequestLoggingFilter())
48+
.filter(swaggerCoverage);
4949
}
5050

5151
@ParameterizedTest

0 commit comments

Comments
 (0)