Skip to content

Commit dec06fb

Browse files
Remove unimplemented sendIntent from RCTLinkingManager
Summary: `sendIntent` is an Android-only Linking API. On iOS the JS layer never reaches the native module at all — `Linking.sendIntent()` returns `Promise.reject(new Error('Unsupported'))` for any non-Android platform, so the exported ObjC method was unreachable. Its body was only `RCTLogError(@"Not implemented: ...")`. It is also absent from `NativeLinkingManagerSpec`, the codegen'd protocol `RCTLinkingManager` conforms to, so a TurboModule call could not dispatch to it either: only spec methods appear on `NativeLinkingManagerSpecJSI`. The `sendIntent` declaration lives on the separate Android spec instead. Removing the dead stub. No behaviour change — the JS-visible rejection on iOS is produced in `Linking.js` and is untouched. Changelog: [Internal] Differential Revision: D117534390
1 parent 94566e2 commit dec06fb

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

packages/react-native/Libraries/LinkingIOS/RCTLinkingManager.mm

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,6 @@ - (void)openSettings:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromise
233233
}];
234234
}
235235

236-
RCT_EXPORT_METHOD(
237-
sendIntent : (NSString *)action extras : (NSArray *_Nullable)extras resolve : (RCTPromiseResolveBlock)
238-
resolve reject : (RCTPromiseRejectBlock)reject)
239-
{
240-
RCTLogError(@"Not implemented: %@", NSStringFromSelector(_cmd));
241-
}
242-
243236
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
244237
(const facebook::react::ObjCTurboModule::InitParams &)params
245238
{

0 commit comments

Comments
 (0)