Distinguish failure, stderr, and both in file history status column

Author: samth

render.rkt

@@ -1233,10 +1233,14 @@ in.}
                         [(list rev (struct rendering (_ _ dur timeout unclean stderr _ changed)) log _)
                          (define name (number->string rev))
                          (define url (format "/~a/~a" rev file-path-str))
+                         (define has-unclean? (not (lc-zero? unclean)))
+                         (define has-stderr? (not (lc-zero? stderr)))
                          (define status-text
                            (cond
                              [(not (lc-zero? timeout)) "Timeout"]
-                             [(not (lc-zero? unclean)) "Failure"]
+                             [(and has-unclean? has-stderr?) "Failure + Stderr"]
+                             [has-unclean? "Failure"]
+                             [has-stderr? "Stderr"]
                              [else "Success"]))
                          (define exit-code-text
                            (cond

test-rendering.rkt

@@ -65,6 +65,12 @@
                   (list "raco" "test" test-file-path)
                   (list (make-stdout #"running tests...\n") (make-stderr #"FAILURE: test failed\n"))
                   1)]
+      [(stderr)
+       (make-exit start-ms
+                  end-ms
+                  (list "raco" "test" test-file-path)
+                  (list (make-stdout #"running tests...\n") (make-stderr #"warning: something\n"))
+                  0)]
       [else
        (make-exit start-ms
                   end-ms
@@ -205,9 +211,19 @@
                                 (format "http://localhost/file-history/~a" test-file-path)))
                              (define body (response-body resp))
                              (check-regexp-match #rx"Success" body)
-                             (check-regexp-match #rx"Failure" body)
+                             (check-regexp-match #rx"Failure \\+ Stderr" body)
                              (check-regexp-match #rx"Timeout" body))))
 
+    (test-case "file history page shows stderr status for exit-0 with stderr"
+      (call-with-test-data (lambda ()
+                             (parameterize ([cache/file-mode 'cache])
+                               (make-test-revision 104 #:status 'stderr #:author "carol"))
+                             (define resp
+                               (dispatch-request
+                                (format "http://localhost/file-history/~a" test-file-path)))
+                             (define body (response-body resp))
+                             (check-regexp-match #rx"Stderr" body))))
+
     (test-case "file history page shows exit codes"
       (call-with-test-data (lambda ()
                              (define resp