Eliminate redundant refcounting in the JIT for `LOAD_ATTR_MODULE`

[aisk]

Feature or enhancement

Proposal:

As a follow-up to #134584, we can eliminate redundant ref-counting for LOAD_ATTR_MODULE.

Note that if a module is imported globally (as is most commonly done, at the top of a file), attribute access via LOAD_ATTR_MODULE may be optimized into a constant load. Therefore, this optimization only applies when a module is imported locally, for example, within a function.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

• gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE #143996

[Fidget-Spinner]

I don't think we should optimize for this. This case is very rare and we introduce more complexity to the interpreter.

If you want, perhaps optimize _BINARY_OP or _BINARY_OP_EXTEND instead?

[aisk]

Hi @Fidget-Spinner, thanks for the reply. I’ll give these a try.

[Fidget-Spinner]

I've changed my mind. I think this is worthwhile when we fail to promote globals. Let's do this!