Skip to content

Commit 47266c8

Browse files
committed
fix: address security and reliability issues
- Add curl safety flags (-fsSL) for Volta installation - Fix Bundler version in README (2.4.20 -> 2.4.22) - Add error handling to ECR sync workflow
1 parent 04ce5b4 commit 47266c8

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ jobs:
6161

6262
- name: Sync multi-arch image to ECR
6363
run: |
64+
set -e
6465
docker buildx imagetools create \
6566
--tag public.ecr.aws/z1n0q3w1/base:${{ github.ref_name }} \
6667
polydice/base:${{ github.ref_name }}
68+
echo "Successfully synced to ECR Public"

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ ARG YARN_VERSION=1.22.22
2626
ARG PNPM_VERSION=9.9.0
2727
RUN apt-get update && apt-get install -y --no-install-recommends curl ca-certificates \
2828
&& rm -rf /var/lib/apt/lists/* \
29-
&& curl https://get.volta.sh | bash
29+
&& curl -fsSL https://get.volta.sh | bash
3030
ENV VOLTA_HOME /root/.volta
3131
ENV VOLTA_FEATURE_PNPM=1
3232
ENV PATH $VOLTA_HOME/bin:/usr/local/bin:$PATH

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Polydice's base docker image for Rails applications.
1616

1717
| Version | Ruby | Node.js | Yarn | Bundler | pnpm | ARM64 |
1818
|---------|-------|---------|---------|---------|-------|-------|
19-
| 0.32.0 | 2.7.8 | 18.18.0 | 1.22.22 | 2.4.20 | 9.9.0 ||
19+
| 0.32.0 | 2.7.8 | 18.18.0 | 1.22.22 | 2.4.22 | 9.9.0 ||
2020
| 0.31.2 | 2.7.8 | 18.18.0 | 1.22.22 | 2.4.20 | 9.9.0 ||
2121
| 0.31.1 | 2.7.8 | 18.18.0 | 1.22.19 | 2.4.20 | 8.8.0 ||
2222
| 0.31.0 | 2.7.7 | 18.18.0 | 1.22.19 | 2.4.5 | 8.8.0 ||

0 commit comments

Comments
 (0)