-
Notifications
You must be signed in to change notification settings - Fork 54
BUG: Provider event handlers are disappearing #1919
Copy link
Copy link
Open
Description
There are some event handlers:
...
val uncheckedClient=openFeatureAPI.getClient(UNCHECKED_DOMAIN)
val checkedClient=openFeatureAPI.client
...
uncheckedClient.onProviderConfigurationChanged { eventDetails: EventDetails ->
uncheckedListeners.forEach { it.onChanged(eventDetails) }
}
checkedClient.onProviderConfigurationChanged { eventDetails: EventDetails ->
checkedListeners.forEach { it.onChanged(eventDetails) }
}
uncheckedClient.onProviderReady { eventDetails: EventDetails ->
uncheckedListeners.forEach { it.onChanged(eventDetails) }
}
checkedClient.onProviderReady { eventDetails: EventDetails ->
checkedListeners.forEach { it.onChanged(eventDetails) }
}At some time I noticed that event handler hasn't be invoked.
It was deleted from OpenFeatureAPI.eventSupport after flags were sent to the provider without a domain.
This happens here.
I suppose the EventSupport.getAllDomainNames() should return a copy of keyset.
The same suggestion for ProviderRepository.getAllBoundDomains().
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels