Commit ff6bb1d
committed
Allow empty string as a valid targeting key
The OpenFeature spec defines targeting key as "a string" with no
restriction on empty strings. The TARGETING_KEY_MISSING error code
is for when a key is "not provided" (null), not when it's an empty
string.
Previously, MutableContext rejected empty strings by checking
`!targetingKey.trim().isEmpty()`, treating them the same as null.
This made it impossible to distinguish between "not provided" and
"explicitly set to empty string".
Changes:
- Remove isEmpty check from constructor and setTargetingKey()
- Empty string is now stored and returned by getTargetingKey()
- Null still results in no targeting key being set
- Updated tests to reflect new behavior
- Added explicit tests for empty string targeting key
Signed-off-by: Leo Romanovsky <leo.romanovsky@datadoghq.com>1 parent 8426a9c commit ff6bb1d
2 files changed
Lines changed: 24 additions & 7 deletions
File tree
- src
- main/java/dev/openfeature/sdk
- test/java/dev/openfeature/sdk
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
89 | 90 | | |
90 | 91 | | |
91 | | - | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
Lines changed: 19 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
62 | 78 | | |
63 | 79 | | |
64 | 80 | | |
| |||
0 commit comments