types badge shows incorrect info

[gameroman]

Describe the bug

Badge shows incorrect info

https://npmx.dev/api/registry/badge/types/@archiver/archiver

https://npmx.dev/package/@archiver/archiver

Additional context

No response

Logs

[RevanthPrk]

@gameroman So you mean to say in https://npmx.dev/package/@archiver/archiver, also we should display

Instead of this

am I right?

[gameroman]

No I mean that it should not say missing and instead should say included

Not sure what could be the reason but my guess is something to go with caching

[RYGRIT]

Not sure what could be the reason but my guess is something to go with caching

This doesn't seem to be related to caching. After further investigation, I found that the issue stems from a discrepancy between the logic used for the badge and the logic used for the package page.

For the badge, it only checks the types and typings fields:

npmx.dev/server/api/registry/badge/[type]/[...pkg].get.ts

Line 350 in d26e250

const hasTypes = !!(versionData?.types || versionData?.typings)

However, a much more comprehensive check is performed on the package page:

1. Checks the types and typings fields in package.json.
2. Checks if the exports field contains a types condition.
3. Checks if there is a declaration file in the release files corresponding to the entry file
4. If the package itself doesn't include types, it falls back to checking if a corresponding @types/xxx package exists.

I'm curious if there was a specific consideration (like badge performance) for not aligning these two logic paths? I would be more than happy to align them if there are no such concerns.