Skip to content

Commit 3dfd512

Browse files
authored
test: accept SIGILL aborts in async-hooks tests
Use common.nodeProcessAborted() for the intentional abort path so platform-specific abort signals such as SIGILL are accepted. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63687 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failure Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 4d7996f commit 3dfd512

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/async-hooks/test-emit-after-on-destroyed.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ if (process.argv[2] === 'child') {
5555
child.on('close', common.mustCall((code, signal) => {
5656
if ((common.isAIX ||
5757
(common.isLinux && process.arch === 'x64')) &&
58-
signal === 'SIGABRT') {
58+
common.nodeProcessAborted(code, signal)) {
5959
// XXX: The child process could be aborted due to unknown reasons. Work around it.
6060
} else {
6161
assert.strictEqual(signal, null);

test/async-hooks/test-improper-order.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ if (process.argv[2] === 'child') {
5353

5454
child.on('close', common.mustCall((code, signal) => {
5555
if ((common.isAIX ||
56-
(common.isLinux && process.arch === 'x64')) &&
57-
signal === 'SIGABRT') {
56+
(common.isLinux && process.arch === 'x64')) &&
57+
common.nodeProcessAborted(code, signal)) {
5858
// XXX: The child process could be aborted due to unknown reasons. Work around it.
5959
} else {
6060
assert.strictEqual(signal, null);

test/async-hooks/test-improper-unwind.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ if (process.argv[2] === 'child') {
5858
child.on('close', common.mustCall((code, signal) => {
5959
if ((common.isAIX ||
6060
(common.isLinux && process.arch === 'x64')) &&
61-
signal === 'SIGABRT') {
61+
common.nodeProcessAborted(code, signal)) {
6262
// XXX: The child process could be aborted due to unknown reasons. Work around it.
6363
} else {
6464
assert.strictEqual(signal, null);

0 commit comments

Comments
 (0)