Skip to content

Commit d996029

Browse files
authored
Merge pull request #57644 from nextcloud/chore/refactor-oc-eventsource
refactor(core): migrate `OC.EventSource` from jQuery to native API
2 parents 8920dad + f8c8814 commit d996029

9 files changed

Lines changed: 19 additions & 18 deletions

File tree

core/src/OC/eventsource.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
* SPDX-License-Identifier: AGPL-3.0-or-later
55
*/
66

7-
import $ from 'jquery'
87
import { getRequestToken } from './requesttoken.ts'
98

109
/**
@@ -42,16 +41,18 @@ function OCEventSource(src, data) {
4241
} else {
4342
const iframeId = 'oc_eventsource_iframe_' + OCEventSource.iframeCount
4443
OCEventSource.fallBackSources[OCEventSource.iframeCount] = this
45-
this.iframe = $('<iframe></iframe>')
46-
this.iframe.attr('id', iframeId)
47-
this.iframe.hide()
44+
const iframe = document.createElement('iframe')
45+
iframe.id = iframeId
46+
iframe.style.display = 'none'
4847

4948
joinChar = '&'
5049
if (src.indexOf('?') === -1) {
5150
joinChar = '?'
5251
}
53-
this.iframe.attr('src', src + joinChar + 'fallback=true&fallback_id=' + OCEventSource.iframeCount + '&' + dataStr)
54-
$('body').append(this.iframe)
52+
iframe.src = src + joinChar + 'fallback=true&fallback_id=' + OCEventSource.iframeCount + '&' + dataStr
53+
54+
this.iframe = iframe
55+
document.body.appendChild(this.iframe)
5556
this.useFallBack = true
5657
OCEventSource.iframeCount++
5758
}

dist/9396-9396.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/9396-9396.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-login.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-login.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-update.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-update.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)