chore(workflows): remove cypress cloud

and allow regular cypress tests to run on forks (no secret leaked)
add consistent gating
 for changes
remove empty matrix option
skip performance workflow on forks without it looking like it's failing

Signed-off-by: Anna Larch <anna@nextcloud.com>

Author: miaulalala

.github/workflows/autocheckers.yml

@@ -74,6 +74,9 @@ jobs:
   autocheckers:
     runs-on: ubuntu-latest-low
 
+    needs: changes
+    if: needs.changes.outputs.src != 'false'
+
     strategy:
       matrix:
         php-versions: ['8.2']
@@ -125,4 +128,4 @@ jobs:
 
     steps:
       - name: Summary status
-        run: if ${{ needs.autocheckers.result != 'success' || (needs.changes.outputs.src != 'false' && needs.autoloader.result != 'success') }}; then exit 1; fi
+        run: if ${{ needs.changes.outputs.src != 'false' && (needs.autocheckers.result != 'success' || needs.autoloader.result != 'success') }}; then exit 1; fi

.github/workflows/command-pull-3rdparty.yml

@@ -27,8 +27,23 @@ jobs:
           comment-id: ${{ github.event.comment.id }}
           reactions: '+1'
 
+      - name: Get repository from pull request comment
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
+        id: get-repository
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const pull = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: context.issue.number
+            });
+            const repositoryName = pull.data.head?.repo?.full_name
+            console.log(repositoryName)
+            return repositoryName
+
       - name: Disabled on forks
-        if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
+        if: ${{ fromJSON(steps.get-repository.outputs.result) != github.repository }}
         run: |
           echo 'Can not execute /update-3rdparty on forks'
           exit 1

.github/workflows/cypress.yml

@@ -41,12 +41,6 @@ jobs:
       PUPPETEER_SKIP_DOWNLOAD: true
 
     steps:
-      - name: Disabled on forks
-        if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
-        run: |
-          echo 'Can not run cypress on forks'
-          exit 1
-
       - name: Checkout server
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
@@ -176,10 +170,6 @@ jobs:
           # We already installed the dependencies in the init job
           install: false
           component: ${{ matrix.containers == 'component' }}
-          group: ${{ matrix.use-cypress-cloud && matrix.containers == 'component' && 'Run component' || matrix.use-cypress-cloud && 'Run E2E' || '' }}
-          # cypress env
-          ci-build-id: ${{ matrix.use-cypress-cloud && format('{0}-{1}', github.sha, github.run_number) || '' }}
-          tag: ${{ matrix.use-cypress-cloud && github.event_name || '' }}
         env:
           # Needs to be prefixed with CYPRESS_
           CYPRESS_BRANCH: ${{ env.BRANCH }}
@@ -188,7 +178,6 @@ jobs:
           # Needed for some specific code workarounds
           TESTING: true
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
           SPLIT: ${{ matrix.total-containers }}
           SPLIT_INDEX: ${{ matrix.containers == 'component' && 0 || matrix.containers }}
           SPLIT_RANDOM_SEED: ${{ github.run_id }}

.github/workflows/files-external-sftp.yml

@@ -73,7 +73,7 @@ jobs:
       - name: Set up sftpd
         run: |
           sudo mkdir /tmp/sftp
-          sudo chown -R 0777 /tmp/sftp
+          sudo chmod -R 0777 /tmp/sftp
           if [[ '${{ matrix.sftpd }}' == 'openssh' ]]; then docker run -p 2222:22 --name sftp -d -v /tmp/sftp:/home/test atmoz/sftp 'test:test:::data'; fi
 
       - name: Set up php ${{ matrix.php-versions }}

.github/workflows/integration-dav.yml

@@ -20,21 +20,21 @@ jobs:
 
     steps:
       - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
-        id: changes
-        continue-on-error: true
-        with:
-          filters: |
-            src:
-              - '.github/workflows/**'
-              - '3rdparty/**'
-              - '**/*.php'
-              - '**/lib/**'
-              - '**/tests/**'
-              - '**/vendor-bin/**'
-              - 'build/integration/**'
-              - '.php-cs-fixer.dist.php'
-              - 'composer.json'
-              - 'composer.lock'
+      id: changes
+      continue-on-error: true
+      with:
+        filters: |
+          src:
+            - '.github/workflows/**'
+            - '3rdparty/**'
+            - '**/*.php'
+            - '**/lib/**'
+            - '**/tests/**'
+            - '**/vendor-bin/**'
+            - 'build/integration/**'
+            - '.php-cs-fixer.dist.php'
+            - 'composer.json'
+            - 'composer.lock'
 
   integration-caldav:
     runs-on: ubuntu-latest
@@ -45,76 +45,76 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['8.2']
-        endpoint: ['old', 'new']
-        service: ['CalDAV', 'CardDAV']
+      php-versions: ['8.2']
+      endpoint: ['old', 'new']
+      service: ['CalDAV', 'CardDAV']
 
     name: ${{ matrix.service }} (${{ matrix.endpoint }} endpoint) php${{ matrix.php-versions }}
 
     steps:
-        - name: Checkout server
-          uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-          with:
-            persist-credentials: false
-            submodules: true
-
-        - name: Set up php ${{ matrix.php-versions }}
-          uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
-          timeout-minutes: 5
-          with:
-            php-version: ${{ matrix.php-versions }}
-            # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
-            extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
-            coverage: 'none'
-            ini-file: development
-          env:
-            GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-        - name: Set up Python
-          uses: LizardByte/actions/actions/setup_python@70bb8d394d1c92f6113aeec6ae9cc959a5763d15 # v2026.227.200013
-          with:
-            python-version: '2.7'
-
-        - name: Set up CalDAVTester
-          run: |
-            git clone --depth=1 https://github.com/apple/ccs-caldavtester.git CalDAVTester
-            git clone --depth=1 https://github.com/apple/ccs-pycalendar.git pycalendar
-
-        - name: Set up Nextcloud
-          run: |
-            mkdir data
-            ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
-            # disable the trashbin, so recurrent deletion of the same object works
-            ./occ config:app:set dav calendarRetentionObligation --value=0
-            # Prepare users
-            OC_PASS=user01 ./occ user:add --password-from-env user01
-            OC_PASS=user02 ./occ user:add --password-from-env user02
-            # Prepare calendars
-            ./occ dav:create-calendar user01 calendar
-            ./occ dav:create-calendar user01 shared
-            ./occ dav:create-calendar user02 calendar
-            # Prepare address books
-            ./occ dav:create-addressbook user01 addressbook
-            ./occ dav:create-addressbook user02 addressbook
-
-        - name: Run Nextcloud
-          run: |
-            php -S localhost:8888 &
-
-        - name: Run CalDAVTester
-          run: |
-            cp "apps/dav/tests/testsuits/caldavtest/serverinfo-${{ matrix.endpoint }}${{ matrix.endpoint == 'old' && (matrix.service == 'CardDAV' && '-carddav' || '-caldav') || '' }}-endpoint.xml" "apps/dav/tests/testsuits/caldavtest/serverinfo.xml"
-            pushd CalDAVTester
-            PYTHONPATH="../pycalendar/src" python testcaldav.py --print-details-onfail --basedir "../apps/dav/tests/testsuits/caldavtest" -o cdt.txt \
-              "${{ matrix.service }}/current-user-principal.xml" \
-              "${{ matrix.service }}/sync-report.xml" \
-              ${{ matrix.endpoint == 'new' && format('{0}/sharing-{1}.xml', matrix.service, matrix.service == 'CalDAV' && 'calendars' || 'addressbooks') || ';' }}
-            popd
-
-        - name: Print Nextcloud logs
-          if: always()
-          run: |
-            cat data/nextcloud.log
+      - name: Checkout server
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          persist-credentials: false
+          submodules: true
+
+      - name: Set up php ${{ matrix.php-versions }}
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
+        timeout-minutes: 5
+        with:
+          php-version: ${{ matrix.php-versions }}
+          # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
+          extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
+          coverage: 'none'
+          ini-file: development
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Set up Python
+        uses: LizardByte/actions/actions/setup_python@70bb8d394d1c92f6113aeec6ae9cc959a5763d15 # v2026.227.200013
+        with:
+          python-version: '2.7'
+
+      - name: Set up CalDAVTester
+        run: |
+          git clone --depth=1 https://github.com/apple/ccs-caldavtester.git CalDAVTester
+          git clone --depth=1 https://github.com/apple/ccs-pycalendar.git pycalendar
+
+      - name: Set up Nextcloud
+        run: |
+          mkdir data
+          ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
+          # disable the trashbin, so recurrent deletion of the same object works
+          ./occ config:app:set dav calendarRetentionObligation --value=0
+          # Prepare users
+          OC_PASS=user01 ./occ user:add --password-from-env user01
+          OC_PASS=user02 ./occ user:add --password-from-env user02
+          # Prepare calendars
+          ./occ dav:create-calendar user01 calendar
+          ./occ dav:create-calendar user01 shared
+          ./occ dav:create-calendar user02 calendar
+          # Prepare address books
+          ./occ dav:create-addressbook user01 addressbook
+          ./occ dav:create-addressbook user02 addressbook
+
+      - name: Run Nextcloud
+        run: |
+          php -S localhost:8888 &
+
+      - name: Run CalDAVTester
+        run: |
+          cp "apps/dav/tests/testsuits/caldavtest/serverinfo-${{ matrix.endpoint }}${{ matrix.endpoint == 'old' && (matrix.service == 'CardDAV' && '-carddav' || '-caldav') || '' }}-endpoint.xml" "apps/dav/tests/testsuits/caldavtest/serverinfo.xml"
+          pushd CalDAVTester
+          PYTHONPATH="../pycalendar/src" python testcaldav.py --print-details-onfail --basedir "../apps/dav/tests/testsuits/caldavtest" -o cdt.txt \
+            "${{ matrix.service }}/current-user-principal.xml" \
+            "${{ matrix.service }}/sync-report.xml" \
+            ${{ matrix.endpoint == 'new' && format('{0}/sharing-{1}.xml', matrix.service, matrix.service == 'CalDAV' && 'calendars' || 'addressbooks') || ';' }}
+          popd
+
+      - name: Print Nextcloud logs
+        if: always()
+        run: |
+          cat data/nextcloud.log
 
   caldav-integration-summary:
     permissions:
@@ -126,4 +126,4 @@ jobs:
 
     steps:
       - name: Summary status
-        run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-caldav.result != 'success' }}; then exit 1; fi
+      run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-caldav.result != 'success' }}; then exit 1; fi

.github/workflows/integration-s3-primary.yml

@@ -95,7 +95,6 @@ jobs:
 
       - name: Wait for S3
         run: |
-          sleep 10
           curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
 
       - name: Set up Nextcloud

.github/workflows/lint-php-cs.yml

@@ -44,6 +44,9 @@ jobs:
   lint:
     runs-on: ubuntu-latest
 
+    needs: changes
+    if: needs.changes.outputs.src != 'false'
+
     name: php-cs
 
     steps:

.github/workflows/lint-stylelint.yml

@@ -18,9 +18,37 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  changes:
+    runs-on: ubuntu-latest-low
+    permissions:
+      contents: read
+      pull-requests: read
+
+    outputs:
+      src: ${{ steps.changes.outputs.src }}
+
+    steps:
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        id: changes
+        continue-on-error: true
+        with:
+          filters: |
+            src:
+              - '.github/workflows/**'
+              - '**/src/**'
+              - '**/appinfo/info.xml'
+              - 'package.json'
+              - 'package-lock.json'
+              - '**.css'
+              - '**.scss'
+              - '**.vue'
+
   lint:
     runs-on: ubuntu-latest
 
+    needs: changes
+    if: needs.changes.outputs.src != 'false'
+
     name: stylelint
 
     steps:
@@ -51,3 +79,18 @@ jobs:
 
       - name: Lint
         run: npm run stylelint
+
+  summary:
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest-low
+    needs: [changes, lint]
+
+    if: always()
+
+    # This is the summary, we just avoid to rename it so that branch protection rules still match
+    name: stylelint
+
+    steps:
+      - name: Summary status
+        run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi

.github/workflows/node-test.yml

@@ -83,9 +83,6 @@ jobs:
         run: |
           npm ci
 
-#      - name: Test
-#        run: npm run test --if-present
-
       - name: Test and process coverage
         run: npm run test:coverage
 

.github/workflows/object-storage-s3.yml

@@ -111,7 +111,6 @@ jobs:
 
       - name: Wait for S3
         run: |
-          sleep 10
           curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
 
       - name: PHPUnit