Skip to content

Commit cb0f011

Browse files
committed
test(sharing): expand advanced settings before accessing its elements
Tests that access elements inside the Advanced Settings section (hide download, share label, grid view, etc.) must first click "Advanced settings" to expand it. Previously these tests relied on buggy auto-expand behavior that occurred when permissions didn't match bundled values.
1 parent 2cdbd7f commit cb0f011

4 files changed

Lines changed: 6 additions & 0 deletions

File tree

cypress/e2e/files_sharing/public-share/default-view.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ describe('files_sharing: Public share - setting the default view mode', () => {
7676
.findByRole('button', { name: /Actions/i })
7777
.click()
7878
cy.findByRole('menuitem', { name: /Customize link/i }).click()
79+
cy.findByRole('button', { name: /Advanced settings/i }).click()
7980
cy.findByRole('checkbox', { name: /Show files in grid view/i })
8081
.scrollIntoView()
8182
cy.findByRole('checkbox', { name: /Show files in grid view/i })

cypress/e2e/files_sharing/public-share/download.cy.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ describe('files_sharing: Public share - downloading files', { testIsolation: tru
195195
triggerActionForFile('test', 'details')
196196

197197
openLinkShareDetails(0)
198+
cy.findByRole('button', { name: /advanced settings/i }).click()
198199

199200
cy.intercept('PUT', '**/ocs/v2.php/apps/files_sharing/api/v1/shares/*').as('update')
200201

@@ -210,12 +211,14 @@ describe('files_sharing: Public share - downloading files', { testIsolation: tru
210211
cy.wait('@update')
211212

212213
openLinkShareDetails(0)
214+
cy.findByRole('button', { name: /advanced settings/i }).click()
213215
cy.findByRole('checkbox', { name: /hide download/i })
214216
.should('be.checked')
215217

216218
cy.reload()
217219

218220
openLinkShareDetails(0)
221+
cy.findByRole('button', { name: /advanced settings/i }).click()
219222
cy.findByRole('checkbox', { name: /hide download/i })
220223
.should('be.checked')
221224
})

cypress/e2e/files_sharing/public-share/sidebar-tab.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ describe('files_sharing: sidebar tab', () => {
2727
it('correctly lists shares by label with special characters', () => {
2828
createLinkShare({ user: alice }, 'test')
2929
openLinkShareDetails(0)
30+
cy.findByRole('button', { name: /advanced settings/i }).click()
3031
cy.findByRole('textbox', { name: /share label/i })
3132
.should('be.visible')
3233
.type('Alice\' share')

cypress/e2e/files_sharing/public-share/view_view-only-no-download.cy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ describe('files_sharing: Public share - View only', { testIsolation: true }, ()
4444
.should('be.visible')
4545
cy.get('[data-cy-files-sharing-share-permissions-bundle="read-only"]')
4646
.click()
47+
cy.findByRole('button', { name: /advanced settings/i }).click()
4748
cy.findByRole('checkbox', { name: 'Hide download' })
4849
.check({ force: true })
4950
// save the update

0 commit comments

Comments
 (0)