Skip to content

Commit e08570f

Browse files
Youssef1313Copilot
authored and
baywet
committed
fix: differentiate unset value from null value in OpenApiSchema.Const (#2936)
* Differentiate unset value from null value in OpenApiSchema.Const * Fix for ref * Fix default for * Different approach * Fix deserializing of const null * chore: update performance benchmark reports (#2) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * chore(benchmark): update benchmark reports Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
1 parent bc11356 commit e08570f

17 files changed

Lines changed: 257 additions & 115 deletions

‎performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report-github.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ WarmupCount=3
1212
```
1313
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated |
1414
|------------- |-------------:|--------------:|-------------:|-----------:|-----------:|----------:|-------------:|
15-
| PetStoreYaml | 232.0 μs | 56.09 μs | 3.07 μs | 76.1719 | 9.7656 | - | 314.13 KB |
16-
| PetStoreJson | 117.3 μs | 10.56 μs | 0.58 μs | 42.9688 | 7.3242 | - | 176.27 KB |
17-
| GHESYaml | 621,674.1 μs | 152,892.95 μs | 8,380.58 μs | 45000.0000 | 19000.0000 | 3000.0000 | 256630.98 KB |
18-
| GHESJson | 264,154.1 μs | 490,035.63 μs | 26,860.51 μs | 18000.0000 | 10000.0000 | 2000.0000 | 113802.94 KB |
19-
| GHESNextYaml | 777,958.3 μs | 269,413.33 μs | 14,767.45 μs | 80000.0000 | 20000.0000 | 3000.0000 | 452706.23 KB |
20-
| GHESNextJson | 432,900.8 μs | 561,774.69 μs | 30,792.77 μs | 54000.0000 | 14000.0000 | 3000.0000 | 314472.13 KB |
15+
| PetStoreYaml | 352.2 μs | 299.63 μs | 16.42 μs | 89.8438 | 15.6250 | - | 367.82 KB |
16+
| PetStoreJson | 147.2 μs | 88.89 μs | 4.87 μs | 48.8281 | - | - | 202.1 KB |
17+
| GHESYaml | 673,081.0 μs | 446,393.95 μs | 24,468.36 μs | 54000.0000 | 20000.0000 | 3000.0000 | 309626.63 KB |
18+
| GHESJson | 329,204.5 μs | 228,948.96 μs | 12,549.47 μs | 24000.0000 | 13000.0000 | 3000.0000 | 139236.93 KB |
19+
| GHESNextYaml | 863,940.5 μs | 152,558.37 μs | 8,362.24 μs | 91000.0000 | 21000.0000 | 3000.0000 | 511080.8 KB |
20+
| GHESNextJson | 485,171.6 μs | 68,963.33 μs | 3,780.11 μs | 58000.0000 | 14000.0000 | 3000.0000 | 342912.2 KB |

‎performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.csv‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Method,Job,AnalyzeLaunchVariance,EvaluateOverhead,MaxAbsoluteError,MaxRelativeError,MinInvokeCount,MinIterationTime,OutlierMode,Affinity,EnvironmentVariables,Jit,LargeAddressAware,Platform,PowerPlanMode,Runtime,AllowVeryLargeObjects,Concurrent,CpuGroups,Force,HeapAffinitizeMask,HeapCount,NoAffinitize,RetainVm,Server,Arguments,BuildConfiguration,Clock,EngineFactory,NuGetReferences,Toolchain,IsMutator,InvocationCount,IterationCount,IterationTime,LaunchCount,MaxIterationCount,MaxWarmupIterationCount,MemoryRandomization,MinIterationCount,MinWarmupIterationCount,RunStrategy,UnrollFactor,WarmupCount,Mean,Error,StdDev,Gen0,Gen1,Gen2,Allocated
2-
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,232.0 μs,56.09 μs,3.07 μs,76.1719,9.7656,0.0000,314.13 KB
3-
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,117.3 μs,10.56 μs,0.58 μs,42.9688,7.3242,0.0000,176.27 KB
4-
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"621,674.1 μs","152,892.95 μs","8,380.58 μs",45000.0000,19000.0000,3000.0000,256630.98 KB
5-
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"264,154.1 μs","490,035.63 μs","26,860.51 μs",18000.0000,10000.0000,2000.0000,113802.94 KB
6-
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"777,958.3 μs","269,413.33 μs","14,767.45 μs",80000.0000,20000.0000,3000.0000,452706.23 KB
7-
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"432,900.8 μs","561,774.69 μs","30,792.77 μs",54000.0000,14000.0000,3000.0000,314472.13 KB
2+
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,352.2 μs,299.63 μs,16.42 μs,89.8438,15.6250,0.0000,367.82 KB
3+
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,147.2 μs,88.89 μs,4.87 μs,48.8281,0.0000,0.0000,202.1 KB
4+
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"673,081.0 μs","446,393.95 μs","24,468.36 μs",54000.0000,20000.0000,3000.0000,309626.63 KB
5+
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"329,204.5 μs","228,948.96 μs","12,549.47 μs",24000.0000,13000.0000,3000.0000,139236.93 KB
6+
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"863,940.5 μs","152,558.37 μs","8,362.24 μs",91000.0000,21000.0000,3000.0000,511080.8 KB
7+
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,111111111111,Empty,RyuJit,Default,Arm64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"485,171.6 μs","68,963.33 μs","3,780.11 μs",58000.0000,14000.0000,3000.0000,342912.2 KB

‎performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.html‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html lang='en'>
33
<head>
44
<meta charset='utf-8' />
5-
<title>performance.Descriptions-20260708-084315</title>
5+
<title>performance.Descriptions-20260714-084517</title>
66

77
<style type="text/css">
88
table { border-collapse: collapse; display: block; width: 100%; overflow: auto; }
@@ -26,12 +26,12 @@
2626
<table>
2727
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
2828
</tr>
29-
</thead><tbody><tr><td>PetStoreYaml</td><td>232.0 &mu;s</td><td>56.09 &mu;s</td><td>3.07 &mu;s</td><td>76.1719</td><td>9.7656</td><td>-</td><td>314.13 KB</td>
30-
</tr><tr><td>PetStoreJson</td><td>117.3 &mu;s</td><td>10.56 &mu;s</td><td>0.58 &mu;s</td><td>42.9688</td><td>7.3242</td><td>-</td><td>176.27 KB</td>
31-
</tr><tr><td>GHESYaml</td><td>621,674.1 &mu;s</td><td>152,892.95 &mu;s</td><td>8,380.58 &mu;s</td><td>45000.0000</td><td>19000.0000</td><td>3000.0000</td><td>256630.98 KB</td>
32-
</tr><tr><td>GHESJson</td><td>264,154.1 &mu;s</td><td>490,035.63 &mu;s</td><td>26,860.51 &mu;s</td><td>18000.0000</td><td>10000.0000</td><td>2000.0000</td><td>113802.94 KB</td>
33-
</tr><tr><td>GHESNextYaml</td><td>777,958.3 &mu;s</td><td>269,413.33 &mu;s</td><td>14,767.45 &mu;s</td><td>80000.0000</td><td>20000.0000</td><td>3000.0000</td><td>452706.23 KB</td>
34-
</tr><tr><td>GHESNextJson</td><td>432,900.8 &mu;s</td><td>561,774.69 &mu;s</td><td>30,792.77 &mu;s</td><td>54000.0000</td><td>14000.0000</td><td>3000.0000</td><td>314472.13 KB</td>
29+
</thead><tbody><tr><td>PetStoreYaml</td><td>352.2 &mu;s</td><td>299.63 &mu;s</td><td>16.42 &mu;s</td><td>89.8438</td><td>15.6250</td><td>-</td><td>367.82 KB</td>
30+
</tr><tr><td>PetStoreJson</td><td>147.2 &mu;s</td><td>88.89 &mu;s</td><td>4.87 &mu;s</td><td>48.8281</td><td>-</td><td>-</td><td>202.1 KB</td>
31+
</tr><tr><td>GHESYaml</td><td>673,081.0 &mu;s</td><td>446,393.95 &mu;s</td><td>24,468.36 &mu;s</td><td>54000.0000</td><td>20000.0000</td><td>3000.0000</td><td>309626.63 KB</td>
32+
</tr><tr><td>GHESJson</td><td>329,204.5 &mu;s</td><td>228,948.96 &mu;s</td><td>12,549.47 &mu;s</td><td>24000.0000</td><td>13000.0000</td><td>3000.0000</td><td>139236.93 KB</td>
33+
</tr><tr><td>GHESNextYaml</td><td>863,940.5 &mu;s</td><td>152,558.37 &mu;s</td><td>8,362.24 &mu;s</td><td>91000.0000</td><td>21000.0000</td><td>3000.0000</td><td>511080.8 KB</td>
34+
</tr><tr><td>GHESNextJson</td><td>485,171.6 &mu;s</td><td>68,963.33 &mu;s</td><td>3,780.11 &mu;s</td><td>58000.0000</td><td>14000.0000</td><td>3000.0000</td><td>342912.2 KB</td>
3535
</tr></tbody></table>
3636
</body>
3737
</html>

‎performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.json‎

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

‎performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.EmptyModels-report-github.md‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,31 @@ WarmupCount=3
1212
```
1313
| Method | Mean | Error | StdDev | Gen0 | Allocated |
1414
|---------------------------- |-----------:|-----------:|----------:|-------:|----------:|
15-
| EmptyApiCallback | 1.646 ns | 0.6629 ns | 0.0363 ns | 0.0077 | 32 B |
16-
| EmptyApiComponents | 3.068 ns | 0.5393 ns | 0.0296 ns | 0.0249 | 104 B |
17-
| EmptyApiContact | 1.928 ns | 0.1985 ns | 0.0109 ns | 0.0115 | 48 B |
18-
| EmptyApiDiscriminator | 1.717 ns | 0.4121 ns | 0.0226 ns | 0.0096 | 40 B |
19-
| EmptyDocument | 299.059 ns | 22.2169 ns | 1.2178 ns | 0.2713 | 1136 B |
20-
| EmptyApiEncoding | 2.057 ns | 0.2635 ns | 0.0144 ns | 0.0134 | 56 B |
21-
| EmptyApiExample | 1.878 ns | 2.1182 ns | 0.1161 ns | 0.0134 | 56 B |
22-
| EmptyApiExternalDocs | 1.578 ns | 1.1661 ns | 0.0639 ns | 0.0096 | 40 B |
23-
| EmptyApiHeader | 2.258 ns | 2.2673 ns | 0.1243 ns | 0.0191 | 80 B |
24-
| EmptyApiInfo | 2.272 ns | 1.0395 ns | 0.0570 ns | 0.0191 | 80 B |
25-
| EmptyApiLicense | 1.711 ns | 1.5825 ns | 0.0867 ns | 0.0115 | 48 B |
26-
| EmptyApiLink | 2.251 ns | 2.9816 ns | 0.1634 ns | 0.0172 | 72 B |
27-
| EmptyApiMediaType | 1.821 ns | 1.1297 ns | 0.0619 ns | 0.0134 | 56 B |
28-
| EmptyApiOAuthFlow | 1.793 ns | 1.1581 ns | 0.0635 ns | 0.0134 | 56 B |
29-
| EmptyApiOAuthFlows | 2.447 ns | 0.5327 ns | 0.0292 ns | 0.0134 | 56 B |
30-
| EmptyApiOperation | 48.119 ns | 1.3899 ns | 0.0762 ns | 0.0899 | 376 B |
31-
| EmptyApiParameter | 2.861 ns | 3.9520 ns | 0.2166 ns | 0.0230 | 96 B |
32-
| EmptyApiPathItem | 2.214 ns | 0.2237 ns | 0.0123 ns | 0.0153 | 64 B |
33-
| EmptyApiPaths | 43.001 ns | 3.9765 ns | 0.2180 ns | 0.0592 | 248 B |
34-
| EmptyApiRequestBody | 1.877 ns | 0.4134 ns | 0.0227 ns | 0.0115 | 48 B |
35-
| EmptyApiResponse | 2.089 ns | 0.0827 ns | 0.0045 ns | 0.0134 | 56 B |
36-
| EmptyApiResponses | 43.530 ns | 0.3726 ns | 0.0204 ns | 0.0592 | 248 B |
37-
| EmptyApiSchema | 11.004 ns | 0.7435 ns | 0.0408 ns | 0.1224 | 512 B |
38-
| EmptyApiSecurityRequirement | 7.082 ns | 1.8803 ns | 0.1031 ns | 0.0249 | 104 B |
39-
| EmptyApiSecurityScheme | 2.782 ns | 0.2327 ns | 0.0128 ns | 0.0210 | 88 B |
40-
| EmptyApiServer | 1.932 ns | 0.9701 ns | 0.0532 ns | 0.0115 | 48 B |
41-
| EmptyApiServerVariable | 1.967 ns | 0.2259 ns | 0.0124 ns | 0.0115 | 48 B |
42-
| EmptyApiTag | 1.939 ns | 0.7970 ns | 0.0437 ns | 0.0115 | 48 B |
15+
| EmptyApiCallback | 1.751 ns | 0.2856 ns | 0.0157 ns | 0.0077 | 32 B |
16+
| EmptyApiComponents | 3.097 ns | 0.9298 ns | 0.0510 ns | 0.0249 | 104 B |
17+
| EmptyApiContact | 2.013 ns | 1.0469 ns | 0.0574 ns | 0.0115 | 48 B |
18+
| EmptyApiDiscriminator | 1.777 ns | 0.5696 ns | 0.0312 ns | 0.0096 | 40 B |
19+
| EmptyDocument | 287.564 ns | 10.2224 ns | 0.5603 ns | 0.2713 | 1136 B |
20+
| EmptyApiEncoding | 2.097 ns | 1.1678 ns | 0.0640 ns | 0.0134 | 56 B |
21+
| EmptyApiExample | 2.050 ns | 0.7205 ns | 0.0395 ns | 0.0134 | 56 B |
22+
| EmptyApiExternalDocs | 1.774 ns | 0.4241 ns | 0.0232 ns | 0.0096 | 40 B |
23+
| EmptyApiHeader | 2.462 ns | 1.3315 ns | 0.0730 ns | 0.0191 | 80 B |
24+
| EmptyApiInfo | 2.572 ns | 2.5960 ns | 0.1423 ns | 0.0191 | 80 B |
25+
| EmptyApiLicense | 1.982 ns | 0.1459 ns | 0.0080 ns | 0.0115 | 48 B |
26+
| EmptyApiLink | 2.504 ns | 0.1151 ns | 0.0063 ns | 0.0172 | 72 B |
27+
| EmptyApiMediaType | 2.158 ns | 0.0825 ns | 0.0045 ns | 0.0134 | 56 B |
28+
| EmptyApiOAuthFlow | 2.239 ns | 1.2433 ns | 0.0681 ns | 0.0134 | 56 B |
29+
| EmptyApiOAuthFlows | 2.104 ns | 0.4341 ns | 0.0238 ns | 0.0134 | 56 B |
30+
| EmptyApiOperation | 46.730 ns | 5.2571 ns | 0.2882 ns | 0.0899 | 376 B |
31+
| EmptyApiParameter | 2.879 ns | 0.6769 ns | 0.0371 ns | 0.0230 | 96 B |
32+
| EmptyApiPathItem | 2.173 ns | 0.3015 ns | 0.0165 ns | 0.0153 | 64 B |
33+
| EmptyApiPaths | 41.833 ns | 4.7467 ns | 0.2602 ns | 0.0592 | 248 B |
34+
| EmptyApiRequestBody | 1.980 ns | 0.7034 ns | 0.0386 ns | 0.0115 | 48 B |
35+
| EmptyApiResponse | 2.033 ns | 0.5751 ns | 0.0315 ns | 0.0134 | 56 B |
36+
| EmptyApiResponses | 41.616 ns | 2.3761 ns | 0.1302 ns | 0.0592 | 248 B |
37+
| EmptyApiSchema | 10.349 ns | 4.5393 ns | 0.2488 ns | 0.1224 | 512 B |
38+
| EmptyApiSecurityRequirement | 6.803 ns | 1.1485 ns | 0.0630 ns | 0.0249 | 104 B |
39+
| EmptyApiSecurityScheme | 2.651 ns | 0.4362 ns | 0.0239 ns | 0.0210 | 88 B |
40+
| EmptyApiServer | 1.881 ns | 1.1119 ns | 0.0609 ns | 0.0115 | 48 B |
41+
| EmptyApiServerVariable | 1.904 ns | 1.3084 ns | 0.0717 ns | 0.0115 | 48 B |
42+
| EmptyApiTag | 1.917 ns | 0.5099 ns | 0.0280 ns | 0.0115 | 48 B |

0 commit comments

Comments
 (0)