|
1 | 1 | # C#/WinRT Contributor's Guide |
2 | 2 |
|
3 | | -Below is our guidance for how to build the repo, report issues, propose new features, and submit contributions via Pull Requests (PRs). |
| 3 | +This guide explains how to report issues, propose features, build the repository, and submit PRs. |
4 | 4 |
|
5 | | -## Building the C#/WinRT repo |
| 5 | +1. [Find or File an Issue First](#find-or-file-an-issue-first) |
| 6 | +2. [Working on a Fix or Feature After Approvals](#working-on-a-fix-or-feature-after-approvals) |
| 7 | +3. [Building the repo](#building-the-repo) |
6 | 8 |
|
7 | | -C#/WinRT currently requires the following packages, or newer, to build: |
| 9 | +## Find or File an Issue First |
8 | 10 |
|
9 | | -- [Visual Studio 17.0](https://visualstudio.microsoft.com/downloads/) |
10 | | -- [.NET 8.0 SDK](https://dotnet.microsoft.com/download/dotnet/8.0) |
11 | | -- [nuget.exe 5.9](https://www.nuget.org/downloads) |
12 | | -- Microsoft.WindowsAppSDK.Foundation 1.8.250831001 |
| 11 | +Before starting any work to submit a PR, **find or file an issue first**. This ensures no duplicated effort and keeps collaboration efficient. |
13 | 12 |
|
14 | | -The [`build.cmd`](src/build.cmd) script takes care of all related configuration steps and is the simplest way to get started building C#/WinRT. It installs prerequisites such as `nuget.exe` and the .NET 6 SDK, configures the environment to use .NET 6 (creating a `global.json` if necessary), builds the compiler, and builds and executes the unit tests. To build C#/WinRT, follow these steps: |
| 13 | +Check both open and closed issues before filing a new one. If none matches your case, file a new issue. |
15 | 14 |
|
16 | | -- Open a Visual Studio Developer command prompt pointing at the repo. |
17 | | -- Run `src\build.cmd`. |
18 | | -- To launch the project in Visual Studio, run `devenv src\cswinrt.sln` from the same command prompt. This will inherit the necessary environment. |
| 15 | +### When to File an Issue |
19 | 16 |
|
20 | | -**Note:** By default, the projects for various [Projections](src/Projections) only generate source files for Release configurations, where `cswinrt.exe` can execute in seconds. To generate sources for the [Projections](src/Projections) projects on Debug configurations, set the project property `GenerateTestProjection` to `true`. This configuration permits a faster inner loop in Visual Studio. In either case, existing projection sources under the "Generated Files" folder will still be compiled into the projection assembly. |
| 17 | +* Unsure if it’s a bug or feature request |
| 18 | + * → [File an Issue](https://github.com/microsoft/CsWinRT/issues/new/choose) |
| 19 | +* Have a question not answered in the docs |
| 20 | + * → [Post a Discussion](https://github.com/microsoft/CsWinRT/discussions) |
| 21 | +* Want to propose or confirm a planned feature |
| 22 | + * → [Post a Discussion](https://github.com/microsoft/CsWinRT/discussions) |
21 | 23 |
|
22 | | -### Customizing `build.cmd` options |
23 | | - |
24 | | -There are several settings that can be set with `build.cmd` that you might not know about without studying the code. The build settings and defaults are as follows. |
25 | | - |
26 | | -```cmd |
27 | | -build.cmd [Platform] [Configuration] [VersionNumber] [VersionString] [AssemblyVersion] |
28 | | -``` |
| 24 | +### What to Describe |
29 | 25 |
|
30 | | -| Parameter | Value(s) | |
31 | | -|-|-| |
32 | | -| Platform | *x64 \| x86 | Default is `x64` |
33 | | -| Configuration | *Release \| Debug | |
34 | | -| VersionNumber | *0.0.0.0 | |
35 | | -| VersionString | *0.0.0-private.0 | |
36 | | -| AssemblyVersion | *0.0.0.0 | |
37 | | -\*Default value |
| 26 | +* Versions of .NET, C#/WinRT, and SDK projections |
| 27 | +* Tools and IDEs used (e.g., VS 2022, VS Code) |
| 28 | +* Build version of Windows used |
| 29 | +* **Detailed reproduction steps** (most important) |
| 30 | +* Full error text or screenshots |
| 31 | +* Note if you plan to implement the fix/feature yourself |
38 | 32 |
|
39 | | -**Examples** |
| 33 | +> [!IMPORTANT] |
| 34 | +> **DO NOT** post "+1", "me too", or similar comments ー they just add noise to an issue. |
| 35 | +> If you don't have any additional info/context to add but would like to indicate that you're affected by the issue, upvote the original issue by reacting with 😊 or 👍 emoji and post your context if necessary. This way we can actually measure how impactful an issue is. |
40 | 36 |
|
41 | | -- Building in Release mode for platform x64, and creates a 0.0.0-private.0.nupkg |
42 | | - ```cmd |
43 | | - build.cmd |
44 | | - ``` |
45 | | -- Building in Debug mode for platform x86, and creates a 0.0.0-private.0.nupkg |
46 | | - ```cmd |
47 | | - build.cmd x86 Debug |
48 | | - ``` |
49 | | -- Building in Debug mode for platform x64, and creates a 2.0.0-mycswinrt.0.nupkg that has `WinRT.Runtime` with AssemblyVersion of 2.0.0.0 |
50 | | - ```cmd |
51 | | - build.cmd x64 Debug 2.0.0.0 2.0.0-mycswinrt.0 2.0.0.0 |
52 | | - ``` |
53 | | - This is useful if you want to quickly confirm that your private .nupkg is being used by checking the `WinRT.Runtime` assembly version. |
| 37 | +## Working on a Fix or Feature After Approvals |
54 | 38 |
|
55 | | -## Before you start, file an issue |
| 39 | +### 1. Fork and Branch |
56 | 40 |
|
57 | | -Please follow this simple rule to help us eliminate any unnecessary wasted effort & frustration, and ensure an efficient and effective use of everyone's time - yours, ours, and other community members': |
| 41 | +After your proposal is discussed and approved: |
58 | 42 |
|
59 | | -> 👉 If you have a question, think you've discovered an issue, would like to propose a new feature, etc., then find/file an issue **BEFORE** starting work to fix/implement it. |
| 43 | +1. Fork the repo |
| 44 | +2. Clone your fork |
| 45 | +3. Create and push a feature branch |
| 46 | +4. Implement your changes |
| 47 | +5. Test your changes locally |
| 48 | +6. Submit a Pull Request (PR) |
60 | 49 |
|
61 | | -### Search Existing Issues First |
| 50 | +### 2. Agree with CLA |
62 | 51 |
|
63 | | -Before filing a new issue, search existing open and closed issues first: It is likely someone else has found the problem you're seeing, and someone may be working on or have already contributed a fix! |
| 52 | +Most contributions require signing a [Contributor License Agreement (CLA)](https://cla.opensource.microsoft.com), confirming that you own the rights to your contribution and grant Microsoft permission to use it. |
64 | 53 |
|
65 | | -If no existing item describes your issue/feature, great - please file a new issue: |
| 54 | +When you open a pull request, the CLA bot automatically checks whether a signature is required and updates the PR with a status or comment. |
| 55 | +Follow the bot’s instructions if prompted. You only need to complete this process once for all Microsoft repositories that use the CLA bot. |
66 | 56 |
|
67 | | -### File a New Issue |
| 57 | +### 3. Code Review |
68 | 58 |
|
69 | | -* Don't know whether you're reporting an issue or requesting a feature? File an issue |
70 | | -* Have a question that you don't see answered in docs, videos, etc.? File an issue |
71 | | -* Want to know if we're planning on building a particular feature? File an issue |
72 | | -* Found an existing issue that describes yours? Great - upvote and add additional commentary / info / repro-steps / etc. |
| 59 | +Mark your PR as "Ready for Review" when it’s ready for feedback from the team and the community. It may take several review cycles to ensure correctness and stability. |
73 | 60 |
|
74 | | -### Include Issue Details |
| 61 | +### 4. Merge |
75 | 62 |
|
76 | | -**Please include as much information as possible in your issue**. The more information you provide, the more likely your issue/ask will be understood and implemented. Helpful information includes: |
| 63 | +After approvals, your PR will be merged into the main branch and automatically closed. |
77 | 64 |
|
78 | | -* What versions of .NET, C#/WinRT, and the SDK Projection you're using |
79 | | -* What tools and apps you're using (e.g. VS 2019, VSCode, etc.) |
80 | | -* What build of Windows your device is running |
81 | | -* Don't assume we're experts in setting up YOUR environment and don't assume we are experts in YOUR workflow. Teach us to help you! |
82 | | -* **We LOVE detailed repro steps!** What steps do we need to take to reproduce the issue? Assume we love to read repro steps. As much detail as you can stand is probably _barely_ enough detail for us! |
83 | | -* Prefer error message text where possible or screenshots of errors if text cannot be captured |
84 | | -* **If you intend to implement the fix/feature yourself then say so!** If you do not indicate otherwise we will assume that the issue is ours to solve, or may label the issue as `Help-Wanted`. |
| 65 | +Thank you in advance for your contribution! |
85 | 66 |
|
86 | | -### DO NOT post "+1" comments |
| 67 | +## Building the repo |
87 | 68 |
|
88 | | -> ⚠ DO NOT post "+1", "me too", or similar comments - they just add noise to an issue. |
| 69 | +### Prerequisites |
89 | 70 |
|
90 | | -If you don't have any additional info/context to add but would like to indicate that you're affected by the issue, upvote the original issue by clicking its [+😊] button and hitting 👍 (+1) icon. This way we can actually measure how impactful an issue is. |
| 71 | +- [Visual Studio 2026](https://visualstudio.microsoft.com/downloads/) |
| 72 | +- [.NET 10 SDK](https://dotnet.microsoft.com/download/dotnet) |
91 | 73 |
|
92 | | ---- |
| 74 | +### Build steps |
93 | 75 |
|
94 | | -## Development |
95 | | -
|
96 | | -### Fork, Clone, Branch and Create your PR |
| 76 | +1. Open a Visual Studio Developer command prompt in the repo root. |
| 77 | +2. Run a script to install dependencies, set up the environment, build the compiler, and run unit tests. |
| 78 | + ``` |
| 79 | + src\build.cmd |
| 80 | + ``` |
| 81 | +3. (Optional) Open the solution in Visual Studio. This will inherit the necessary environment. |
| 82 | + ``` |
| 83 | + devenv src\cswinrt.slnx |
| 84 | + ``` |
97 | 85 |
|
98 | | -Once you've discussed your proposed feature/fix/etc. with a team member, and you've agreed on an approach or a spec has been written and approved, it's time to start development: |
| 86 | +> [!NOTE] |
| 87 | +> Projection projects under `src/Projections` only generate sources in `Release` by default. To generate them in `Debug`, set the property `GenerateTestProjection` to `true`. This configuration will enable a faster inner loop in Visual Studio. "Generated Files" remain under the Generated Files folder regardless of configuration. |
99 | 88 |
|
100 | | -1. Fork the repo if you haven't already |
101 | | -1. Clone your fork locally |
102 | | -1. Create & push a feature branch |
103 | | -1. Create a Pull Request |
104 | | -1. Work on your changes |
| 89 | +### Customizing `build.cmd` options |
105 | 90 |
|
106 | | -### Code Review |
| 91 | +You can specify platform, configuration, and version parameters: |
107 | 92 |
|
108 | | -When you'd like the team to take a look, (even if the work is not yet fully complete), mark the PR as 'Ready For Review' so that the team can review your work and provide comments, suggestions, and request changes. It may take several cycles, but the end result will be solid, testable, conformant code that is safe for us to merge. |
| 93 | +```cmd |
| 94 | +build.cmd [Platform] [Configuration] [VersionNumber] [VersionString] [AssemblyVersion] |
| 95 | +``` |
109 | 96 |
|
110 | | -### Merge |
| 97 | +| Parameter | Values | Default |
| 98 | +|-|-|-| |
| 99 | +| Platform | `x64 \| x86` | `x64` | |
| 100 | +| Configuration | `Release \| Debug` | `Release` | |
| 101 | +| VersionNumber | \* | `0.0.0.0` | |
| 102 | +| VersionString | \* | `0.0.0-private.0` | |
| 103 | +| AssemblyVersion |\* | `0.0.0.0` | |
111 | 104 |
|
112 | | -Once your code has been reviewed and approved by the requisite number of team members, it will be merged into the master branch. Once merged, your PR will be automatically closed. |
| 105 | +Building in `Release` for `x64`, and creates `0.0.0-private.0.nupkg` |
| 106 | +```cmd |
| 107 | +build.cmd |
| 108 | +``` |
113 | 109 |
|
114 | | ---- |
| 110 | +Building in `Debug` for `x86`, and creates `0.0.0-private.0.nupkg` |
| 111 | +```cmd |
| 112 | +build.cmd x86 Debug |
| 113 | +``` |
115 | 114 |
|
116 | | -## Thank you |
| 115 | +Building in `Debug` for `x64`, and creates `2.0.0-mycswinrt.0.nupkg` that has `WinRT.Runtime` with AssemblyVersion of `2.0.0.0` |
| 116 | +```cmd |
| 117 | +build.cmd x64 Debug 2.0.0.0 2.0.0-mycswinrt.0 2.0.0.0 |
| 118 | +``` |
117 | 119 |
|
118 | | -Thank you in advance for your contribution! |
| 120 | +This is useful if you want to quickly confirm that your private .nupkg is being used by checking the `WinRT.Runtime` assembly version. |
0 commit comments