fix(qt): rcc tracks the files a .qrc references (#42)

`qrc_files` read `node::text` of the `<file>` element, which the XML reader never
sets: an element's characters live in its unnamed text children, as the writer
itself reads them. Every `.qrc`-referenced file was therefore left out of the
`rcc` action's inputs, so a changed resource -- an embedded zip, say -- did not
regenerate the resource source.

The text children are now joined and trimmed, which is what a path split by an
intervening comment and padded with whitespace needs.

A `plugin-logic` case drives the real Qt rule and asserts both resource files
appear in the emitted `qt:rcc:app` action: one plain path, one aliased path whose
text the reader splits. Measured on this machine with the released engine: 22 of
23 cases without the fix, with both resource assertions failing, and 23 of 23
with it.

Author: julixian

rules/qt.cppm

@@ -256,7 +256,12 @@ inline std::vector<std::string> qrc_files(const std::filesystem::path& qrc) {
     if (!mcpp::plugins::xml::parse(read_file(qrc), doc, error)) return out;
     std::function<void(const mcpp::plugins::xml::node&)> walk = [&](const mcpp::plugins::xml::node& n) {
         if (n.name == "file") {
-            std::string text = mcpp::plugins::xml::trim_copy(n.text);
+            // The XML reader stores element text in unnamed child nodes.
+            std::string text;
+            for (auto const& child : n.children) {
+                if (child.name.empty()) text += child.text;
+            }
+            text = mcpp::plugins::xml::trim_copy(text);
             if (!text.empty()) out.push_back(generic(qrc.parent_path() / text));
         }
         for (auto const& c : n.children) walk(c);

tests/plugin-logic/build.mcpp

@@ -446,6 +446,34 @@ int main(int argc, char** argv) {
                        "moc reads no header another build system wrote");
           } },
 
+        { "qt: rcc tracks the resource paths stored in XML text children",
+          with_qt(t::row::linux_gcc())
+              .file("qt/bin/rcc").file("qt/bin/rcc.exe")
+              .file("pkg/res/app.qrc",
+                    "<RCC><qresource prefix=\"/\">\n"
+                    "  <file>assets/greeting.txt</file>\n"
+                    "  <file alias=\"sample.zip\"> \n"
+                    "    data/Sample<!-- split text -->Project.zip \n"
+                    "  </file>\n"
+                    "</qresource></RCC>\n")
+              .file("pkg/res/assets/greeting.txt", "hello\n")
+              .file("pkg/res/data/SampleProject.zip", "resource contents\n"),
+          [] {
+              mcpp::rules::qt::options o;
+              o.root = "../qt";
+              o.modules = {"Core"};
+              o.resources = {"res/app.qrc"};
+              return mcpp::rules::qt::compile(o) ? 0 : 1;
+          },
+          [](const t::result& r, t::checker& c) {
+              c.expect(r.exit_code == 0, "the member succeeds");
+              const auto a = r.line("mcpp:action=", {"qt:rcc:app"});
+              c.expect(a.find("pkg/res/assets/greeting.txt") != std::string::npos,
+                       "rcc tracks a resource relative to the qrc directory");
+              c.expect(a.find("pkg/res/data/SampleProject.zip") != std::string::npos,
+                       "rcc tracks the aliased source after joining and trimming text children");
+          } },
+
         // ── compatibility ───────────────────────────────────────────────────
         { "compat: program_compilers keeps its 0.16.0 answer and says until when",
           t::row::linux_libcxx().file("llvm/bin/clang").file("llvm/bin/clang++"),