Skip to content

Commit 885c574

Browse files
authored
Fix leanvec ood for public-only build and update binaries (#290)
Fixes public-only cpp runtime bindings validation with lack of equivalent header that was added for private interface use with leanvec ood. Also allows runtime bindings validation runs to proceed regardless of whether another fails, making it easier to identify root cause of issues. Lastly, updates CMakeLists.txts for shared examples and cpp runtime bindings to use v0.2.0 binaries as this was investigated initially as a potential cause of the CI issues and should be done anyway
1 parent 64c5fc6 commit 885c574

4 files changed

Lines changed: 18 additions & 3 deletions

File tree

.github/workflows/build-cpp-runtime-bindings.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ jobs:
111111
- name: "IVF public only"
112112
suffix: "-ivf"
113113
enable_ivf: "ON"
114+
fail-fast: false
114115

115116
steps:
116117
- uses: actions/checkout@v6

bindings/cpp/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,14 @@ if (SVS_RUNTIME_ENABLE_LVQ_LEANVEC)
121121
else()
122122
# Links to LTO-enabled static library, requires GCC/G++ 11.2
123123
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11.2" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.3")
124-
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-lto-nightly-2026-02-05-1017.tar.gz"
124+
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.2.0/svs-shared-library-0.2.0-lto-ivf.tar.gz"
125125
CACHE STRING "URL to download SVS shared library")
126126
else()
127127
message(WARNING
128128
"Pre-built LVQ/LeanVec SVS library requires GCC/G++ v.11.2 to apply LTO optimizations."
129129
"Current compiler: ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION}"
130130
)
131-
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-nightly-2026-02-05-1017.tar.gz"
131+
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.2.0/svs-shared-library-0.2.0-ivf.tar.gz"
132132
CACHE STRING "URL to download SVS shared library")
133133
endif()
134134
include(FetchContent)

bindings/cpp/src/training.cpp

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,20 @@ Status LeanVecTrainingData::build(
9090
"LeanVecTrainingData is not supported in this build configuration."
9191
);
9292
}
93+
Status LeanVecTrainingData::build(
94+
LeanVecTrainingData** SVS_UNUSED(training_data),
95+
size_t SVS_UNUSED(dim),
96+
size_t SVS_UNUSED(n),
97+
const float* SVS_UNUSED(x),
98+
size_t SVS_UNUSED(n_q),
99+
const float* SVS_UNUSED(x_q),
100+
size_t SVS_UNUSED(leanvec_dims)
101+
) noexcept {
102+
return Status(
103+
ErrorCode::NOT_IMPLEMENTED,
104+
"LeanVecTrainingData is not supported in this build configuration."
105+
);
106+
}
93107
Status LeanVecTrainingData::destroy(LeanVecTrainingData* SVS_UNUSED(training_data)
94108
) noexcept {
95109
return Status(

examples/cpp/shared/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ find_package(svs QUIET)
2424
if(NOT svs_FOUND)
2525
# If sourcing from pip/conda, the following steps are not necessary, simplifying workflow
2626
# If not found, download tarball from GitHub release and follow steps to fetch and find
27-
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.1.0/svs-shared-library-0.1.0.tar.gz" CACHE STRINGS "URL to download SVS shared library tarball if not found in system")
27+
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.2.0/svs-shared-library-0.2.0.tar.gz" CACHE STRINGS "URL to download SVS shared library tarball if not found in system")
2828

2929
message(STATUS "SVS not found in system, downloading from: ${SVS_URL}")
3030

0 commit comments

Comments
 (0)