Skip to content

Commit 9ee104c

Browse files
committed
Fix scss warnings
1 parent e1af319 commit 9ee104c

File tree

7 files changed

+24
-10
lines changed

7 files changed

+24
-10
lines changed

.github/workflows/master.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ jobs:
3535
- 'mix.exs'
3636
- 'mix.lock'
3737
- 'apps/codebattle/**'
38+
- 'apps/runner/**'
39+
- 'apps/phoenix_gon/**'
3840
- 'config/**'
3941
runner_image:
4042
- 'Containerfile.runner'
@@ -286,7 +288,8 @@ jobs:
286288
response => response.data.jobs,
287289
);
288290
289-
const byName = new Map(jobs.map(job => [job.name, job]));
291+
const safeJobs = (jobs || []).filter(job => job && typeof job.name === "string");
292+
const byName = new Map(safeJobs.map(job => [job.name, job]));
290293
const pending = [];
291294
const failed = [];
292295
@@ -303,7 +306,9 @@ jobs:
303306
}
304307
}
305308
306-
core.info(`pending=[${pending.join(", ")}], failed=[${failed.join(", ")}]`);
309+
core.info(
310+
`jobs_total=${(jobs || []).length}, jobs_named=${safeJobs.length}, pending=[${pending.join(", ")}], failed=[${failed.join(", ")}]`,
311+
);
307312
308313
if (failed.length > 0) {
309314
core.setFailed(`Required checks failed: ${failed.join(", ")}`);

apps/codebattle/assets/css/external.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// IMPORTS & VARIABLES
33
// --------------------------------------------------
44

5+
@use "variables" as *;
6+
57
@font-face {
68
font-family: 'External';
79
src: url('https://yastatic.net/s3/lpc-ext/Young%20Con%202025/YangoHeadline-Black.ttf') format('truetype');
@@ -28,7 +30,6 @@ $dark-red: #b00020;
2830

2931
// Bootstrap override must come *after* variables
3032

31-
@import 'variables';
3233
@import "bootstrap/scss/bootstrap";
3334

3435
// --------------------------------------------------

apps/codebattle/assets/css/landing.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
@use "variables" as *;
12
@import "fonts";
2-
@import "variables";
33
@import "bootstrap/scss/bootstrap";
44

55
.landing {
@@ -613,7 +613,9 @@
613613
}
614614

615615
.btn:hover {
616-
text-decoration: if($link-hover-decoration == underline, none, null);
616+
@if $link-hover-decoration == underline {
617+
text-decoration: none;
618+
}
617619
}
618620

619621
[data-reveal] {

apps/codebattle/assets/css/skeleton.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1+
@use "sass:color";
2+
13
$item-bg: #15202B;
24

35
.cb-text-skeleton {
46
animation: skeleton-loading 1s linear infinite alternate;
57

68
height: 1.2rem;
79
border-radius: 0.25rem;
8-
background-color: lighten($item-bg, 7%);
10+
background-color: color.adjust($item-bg, $lightness: 7%);
911
}
1012

1113
@keyframes skeleton-loading {

apps/codebattle/assets/css/style.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use "variables" as *;
2+
13
$body-bg: #e5e5e5;
24
$cb-text-color: #999;
35
$cb-text-light-color: #ddd;
@@ -84,7 +86,6 @@ $cb-rookie-bg: $iron;
8486
--cb-grade-rookie: #{$cb-rookie-bg};
8587
}
8688

87-
@import "variables";
8889
@import "bootstrap/scss/bootstrap";
8990
@import "nprogress/nprogress.css";
9091
@import "gamePreview";

apps/codebattle/assets/css/tournaments.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use "sass:color";
2+
13
*,
24
*::after,
35
*::before {
@@ -101,9 +103,9 @@
101103
.progress-bar {
102104
background: linear-gradient(
103105
90deg,
104-
darken($gold, 14%) 0%,
106+
color.adjust($gold, $lightness: -14%) 0%,
105107
$gold 52%,
106-
lighten($gold, 8%) 100%
108+
color.adjust($gold, $lightness: 8%) 100%
107109
);
108110
}
109111
}

apps/codebattle/vite.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ export default defineConfig(({ command, mode }) => ({
162162
preprocessorOptions: {
163163
scss: {
164164
includePaths: [path.resolve(__dirname, "assets/css")],
165-
silenceDeprecations: ["mixed-decls"],
165+
quietDeps: true,
166+
silenceDeprecations: ["import"],
166167
},
167168
},
168169
modules: {

0 commit comments

Comments
 (0)