Two SCIMService methods in github/scim.go have implementations that don't match the GitHub API schema:
Both are breaking changes to fix.
Problems:
- Parameters are passed as query parameters, but must be in the body
- Missing return type
UpdateAttributeForSCIMUserOptions.Operations should be an array of objects
- maybe some other; see documentation for these endpoints
UpdateProvisionedOrgMembership
Current signature:
func (s *SCIMService) UpdateProvisionedOrgMembership(ctx context.Context, org, scimUserID string, opts *SCIMUserAttributes) (*Response, error)
Expected signature:
func (s *SCIMService) UpdateProvisionedOrgMembership(ctx context.Context, org, scimUserID string, body UpdateProvisionedOrgMembershipRequest) (*SCIMUserAttributes, *Response, error)
UpdateAttributeForSCIMUser
Current signature:
func (s *SCIMService) UpdateAttributeForSCIMUser(ctx context.Context, org, scimUserID string, opts *UpdateAttributeForSCIMUserOptions) (*Response, error)
Expected signature:
func (s *SCIMService) UpdateAttributeForSCIMUser(ctx context.Context, org, scimUserID string, body UpdateAttributeForSCIMUserRequest) (*SCIMUserAttributes, *Response, error)
Two
SCIMServicemethods in github/scim.go have implementations that don't match the GitHub API schema:Both are breaking changes to fix.
Problems:
UpdateAttributeForSCIMUserOptions.Operationsshould be an array of objectsUpdateProvisionedOrgMembershipCurrent signature:
Expected signature:
UpdateAttributeForSCIMUserCurrent signature:
Expected signature: