We should return ERROR for JSON errors

Author: northrup

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    entitlements-github-plugin (1.2.0)
+    entitlements-github-plugin (1.2.1)
       contracts (~> 0.17.0)
       faraday (~> 2.0)
       faraday-retry (~> 2.0)

lib/entitlements/service/github.rb

@@ -418,8 +418,10 @@ def graphql_http_post_real(query)
             end
             { code: response.code.to_i, data: }
           rescue JSON::ParserError => e
-            # Synthesized 500 below triggers a retry; log at WARN.
-            Entitlements.logger.warn "#{e.class} #{e.message}: #{response.body.inspect}"
+            # JSON parse errors mean the API returned something we can't interpret. The
+            # synthesized 500 below triggers a retry, but the cause is more likely a real
+            # protocol/server problem than a transient network blip, so log at ERROR.
+            Entitlements.logger.error "#{e.class} #{e.message}: #{response.body.inspect}"
             { code: 500, data: { "body" => response.body } }
           end
         rescue => e

spec/unit/entitlements/service/github_spec.rb

@@ -394,10 +394,10 @@
       expect(response).to eq(code: 504, data: { "body" => body })
     end
 
-    it "logs at warn and returns raw text for JSON parsing error" do
+    it "logs at error and returns raw text for JSON parsing error" do
       answer = "mor chicken mor rewardz!"
       stub_request(:post, "https://github.fake/api/v3/graphql").to_return(status: 200, body: answer)
-      expect(logger).to receive(:warn).with("JSON::ParserError unexpected character: 'mor' at line 1 column 1: \"mor chicken mor rewardz!\"")
+      expect(logger).to receive(:error).with("JSON::ParserError unexpected character: 'mor' at line 1 column 1: \"mor chicken mor rewardz!\"")
       response = subject.send(:graphql_http_post_real, "nonsense")
       expect(response).to eq(code: 500, data: { "body" => "mor chicken mor rewardz!" })
     end