Fix some lines with // $ ... // $ MISSING:

Note that when a line is marked `// BAD [NOT DETECTED]` but actually has
an alert, I assume that the `[NOT DETECTED]` is outdated and should be
deleted.

Author: owen-mc

cpp/ql/test/query-tests/Critical/MemoryFreed/test_free.cpp

@@ -41,7 +41,7 @@ void test_post_dominance1(int *a)
 {
     if (condition()) free(a); // $ Source[cpp/double-free] Source[cpp/use-after-free]
     if (condition()) a[2] = 5; // $ MISSING: Alert // BAD [NOT DETECTED]
-    if (condition()) free(a); // $ Source[cpp/double-free] Source[cpp/use-after-free] // $ MISSING: Alert // BAD [NOT DETECTED]
+    if (condition()) free(a); // $ Source[cpp/double-free] Source[cpp/use-after-free] MISSING: Alert // BAD [NOT DETECTED]
     a[2] = 5; // $ Alert[cpp/use-after-free] // BAD
     free(a); // $ Alert[cpp/double-free] // BAD
 }

cpp/ql/test/query-tests/Likely Bugs/Memory Management/StrncpyFlippedArgs/test.cpp

@@ -34,7 +34,7 @@ void test2()
 	wcsncpy(buf1, str, wcslen(str)); // $ Alert // BAD
 	wcsncpy(buf1, str, wcslen(str) + 1); // $ Alert // BAD
 	wcsncpy(buf1, buf2, sizeof(buf2)); // $ Alert // BAD
-	wcsncpy(buf1, buf2, sizeof(buf2) / sizeof(wchar_t)); // $ Alert // $ MISSING: Alert // BAD [NOT DETECTED]
+	wcsncpy(buf1, buf2, sizeof(buf2) / sizeof(wchar_t)); // $ Alert // BAD
 }
 
 void test3()

cpp/ql/test/query-tests/Security/CWE/CWE-193/test.cpp

@@ -39,9 +39,9 @@ void test3(int size) {
 void test4(int size) {
     char* p = (char*)malloc(size - 1);
     char* q = p + (size - 1); // $ MISSING: alloc=L40-1
-    char a = *q; // $ MISSING: deref=L42 // $ MISSING: Alert // BAD [NOT DETECTED]
+    char a = *q; // $ MISSING: deref=L42 Alert // BAD [NOT DETECTED]
     char b = *(q - 1); // GOOD
-    char c = *(q + 1); // $ MISSING: deref=L44+1 // $ MISSING: Alert // BAD [NOT DETECTED]
+    char c = *(q + 1); // $ MISSING: deref=L44+1 Alert // BAD [NOT DETECTED]
     char d = *(q + size); // $ MISSING: Alert // BAD [NOT DETECTED]
     char e = *(q - size); // GOOD
     char f = *(q + size + 1); // $ MISSING: Alert // BAD [NOT DETECTED]
@@ -93,7 +93,7 @@ void test6(int size) {
     }
 
     for (char* p = arr.begin; p <= arr.end; ++p) {
-        *p = 0; // $ MISSING: deref=L83->L91->L96 deref=L83->L95->L96 // $ MISSING: Alert // BAD [NOT DETECTED]
+        *p = 0; // $ MISSING: deref=L83->L91->L96 deref=L83->L95->L96 Alert // BAD [NOT DETECTED]
     }
 
     for (char* p = arr.begin; p < arr.end; ++p) {
@@ -107,7 +107,7 @@ void test7_callee(array_t arr) {
     }
 
     for (char* p = arr.begin; p <= arr.end; ++p) {
-        *p = 0; // $ MISSING: deref=L83->L105->L110 deref=L83->L109->L110 // $ MISSING: Alert // BAD [NOT DETECTED]
+        *p = 0; // $ MISSING: deref=L83->L105->L110 deref=L83->L109->L110 Alert // BAD [NOT DETECTED]
     }
 
     for (char* p = arr.begin; p < arr.end; ++p) {
@@ -154,7 +154,7 @@ void test9(int size) {
     }
 
     for (char* p = arr->begin; p <= arr->end; ++p) {
-        *p = 0; // $ MISSING: deref=L144->L156->L157 // $ MISSING: Alert // BAD [NOT DETECTED]
+        *p = 0; // $ MISSING: deref=L144->L156->L157 Alert // BAD [NOT DETECTED]
     }
 
     for (char* p = arr->begin; p < arr->end; ++p) {
@@ -168,7 +168,7 @@ void test10_callee(array_t *arr) {
     }
 
     for (char* p = arr->begin; p <= arr->end; ++p) {
-        *p = 0; // $ MISSING: deref=L144->L166->L171 deref=L144->L170->L171 // $ MISSING: Alert // BAD [NOT DETECTED]
+        *p = 0; // $ MISSING: deref=L144->L166->L171 deref=L144->L170->L171 Alert // BAD [NOT DETECTED]
     }
 
     for (char* p = arr->begin; p < arr->end; ++p) {
@@ -198,7 +198,7 @@ void test12(unsigned len, unsigned index) {
         return;
     }
 
-    p[index] = '\0'; // $ MISSING: deref=L195->L201 // $ MISSING: Alert // BAD [NOT DETECTED]
+    p[index] = '\0'; // $ MISSING: deref=L195->L201 Alert // BAD [NOT DETECTED]
 }
 
 void test13(unsigned len, unsigned index) {
@@ -703,7 +703,7 @@ void test34(unsigned size) {
 }
 
 void deref(char* q) {
-  char x = *q; // $ MISSING: deref=L714->L705->L706 // $ MISSING: Alert // BAD [NOT DETECTED]
+  char x = *q; // $ MISSING: deref=L714->L705->L706 Alert // BAD [NOT DETECTED]
 }
 
 void test35(size_t size, char* q)

cpp/ql/test/query-tests/Security/CWE/CWE-416/semmle/tests/UseAfterFree/test.cpp

@@ -214,7 +214,7 @@ template<class T> T test15()
 	T* x;
 	use(x); // GOOD
 	delete x; // $ Source
-	use(x); // $ Alert // $ MISSING: Alert // BAD [NOT DETECTED]
+	use(x); // $ Alert // BAD
 }
 void test15runner(void)
 {