Fix performance issue in EXP37-C

Author: mbaluda

c/cert/src/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.ql

@@ -29,5 +29,4 @@ where
     complexArgumentPassedToRealParameter(fc, f, p)
   )
 select fc,
-  "Argument $@ in call to " + f.toString() + " is incompatible with parameter " + p.getTypedName() +
-    ".", fc.getArgument(p.getIndex()) as arg, arg.toString()
+  "Argument $@ in call to " + f.toString() + " is incompatible with the function parameter type.", fc.getArgument(p.getIndex()) as arg, arg.toString()

c/cert/test/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.expected

@@ -1,3 +1,3 @@
-| test.c:83:12:83:16 | call to atan2 | Argument $@ in call to atan2 is incompatible with parameter double (unnamed parameter 0). | test.c:83:18:83:18 | c | c |
-| test.c:93:3:93:12 | call to test_func1 | Argument $@ in call to test_func1 is incompatible with parameter short p1. | test.c:93:14:93:15 | p1 | p1 |
-| test.c:94:3:94:12 | call to test_func1 | Argument $@ in call to test_func1 is incompatible with parameter short p1. | test.c:94:14:94:15 | p2 | p2 |
+| test.c:83:12:83:16 | call to atan2 | Argument $@ in call to atan2 is incompatible with the function parameter type. | test.c:83:18:83:18 | c | c |
+| test.c:93:3:93:12 | call to test_func1 | Argument $@ in call to test_func1 is incompatible with the function parameter type. | test.c:93:14:93:15 | p1 | p1 |
+| test.c:94:3:94:12 | call to test_func1 | Argument $@ in call to test_func1 is incompatible with the function parameter type. | test.c:94:14:94:15 | p2 | p2 |

cpp/common/src/codingstandards/cpp/MistypedFunctionArguments.qll

@@ -82,9 +82,7 @@ private predicate hasZeroParamDecl(Function f) {
 
 // True if this file (or header) was compiled as a C file
 private predicate isCompiledAsC(File f) {
-  f.compiledAsC()
-  or
-  exists(File src | isCompiledAsC(src) | src.getAnIncludedFile() = f)
+  exists(File src | src.compiledAsC() | src.getAnIncludedFile*() = f)
 }
 
 private predicate isTypeInComplexDomain(FloatingPointType type) {