Skip to content

Commit ee27d9f

Browse files
committed
Cosmetic fixes in reporters
1 parent 4a67412 commit ee27d9f

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

reporter.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package httpexpect
22

33
import (
4-
"fmt"
54
"testing"
65

76
"github.com/stretchr/testify/assert"
@@ -21,7 +20,7 @@ func NewAssertReporter(t assert.TestingT) *AssertReporter {
2120

2221
// Errorf implements Reporter.Errorf.
2322
func (r *AssertReporter) Errorf(message string, args ...interface{}) {
24-
r.backend.Fail(fmt.Sprintf(message, args...))
23+
r.backend.Fail(message, args...)
2524
}
2625

2726
// RequireReporter implements Reporter interface using `testify/require'
@@ -37,7 +36,7 @@ func NewRequireReporter(t require.TestingT) *RequireReporter {
3736

3837
// Errorf implements Reporter.Errorf.
3938
func (r *RequireReporter) Errorf(message string, args ...interface{}) {
40-
r.backend.FailNow(fmt.Sprintf(message, args...))
39+
r.backend.FailNow(message, args...)
4140
}
4241

4342
// FatalReporter is a struct that implements the Reporter interface
@@ -47,8 +46,8 @@ type FatalReporter struct {
4746
}
4847

4948
// NewFatalReporter returns a new FatalReporter object.
50-
func NewFatalReporter(backend testing.TB) *FatalReporter {
51-
return &FatalReporter{backend}
49+
func NewFatalReporter(t testing.TB) *FatalReporter {
50+
return &FatalReporter{t}
5251
}
5352

5453
// Errorf implements Reporter.Errorf.

reporter_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ func (m *mockT) Fatalf(format string, args ...interface{}) {
1515
m.fatalfInvoked = true
1616
}
1717

18-
func TestFatalReporter(t *testing.T) {
18+
func TestReporter_FatalReporter(t *testing.T) {
1919
mockBackend := &mockT{}
2020
reporter := NewFatalReporter(mockBackend)
2121

22-
t.Run("Test Errorf", func(t *testing.T) {
22+
t.Run("Errorf", func(t *testing.T) {
2323
reporter.Errorf("Test failed with backend: %v", mockBackend)
2424
assert.True(t, mockBackend.fatalfInvoked)
2525
})

0 commit comments

Comments
 (0)