Uses legacy componentWillMount

[jfrolich]

This component does not work in concurrentMode

[lourd]

Hey Jaap, thanks for noticing and filing an issue!

I went ahead and started work at resolving this on the use-did-mount branch. Can you please review it and also add a test case that makes sure the library is now concurrent mode compliant? Just fork from my branch.

Let me know if you have any questions. Thanks!

[jfrolich]

Not sure I have time to write a test, I don't use this library directly, just wanted to report it :)

[tyscorp]

Changing from componentWillMount to componentDidMount isn't enough as described here: #40

[seansfkelley]

This also triggers warnings when using StrictMode.

[mikecousins]

This now barfs warnings in React v16.9.

[lourd]

I'm gonna ping Dan on Twitter and ask if he can chime in here.

[gaearon]

I’ll take a look on Monday if I don’t forget. However this whole library doesn’t really make sense to me anymore so I’d encourage migrating away from these patterns. For example it wouldn’t work with a streaming renderer. Something using context would probably make more sense.

[mikecousins]

Yeah, it's used in react-document-title. So I guess we'll need to get away from using that or rewrite react-document-title away from react-side-effect. react-helmet also uses it.

[danielweck]

Sorry, I posted my previous comment in the wrong repo! :)