From 787ddfc18fed96210800d75d48d22f2e0b86391a Mon Sep 17 00:00:00 2001 From: "Ronald A. Richardson" Date: Fri, 11 Sep 2026 16:41:44 +0800 Subject: [PATCH] fix(map): invoke leaflet-tile-url instead of passing it by name Opening a place's details threw "A resolved helper cannot be passed as a named argument" and the details tab failed to render. The tile layers passed the helper bare, as @url={{leaflet-tile-url}}, which Glimmer reads as ambiguously a reference or an invocation and refuses. They invoke it now, as @url={{(leaflet-tile-url)}}. The same line was in the zone and service area details and the place details and point map modals, all from the configurable tile provider change (a5a4f1cd), so each of them failed the same way. The helper's own usage comment showed the broken form and is corrected. --- addon/components/modals/place-details.hbs | 2 +- addon/components/modals/point-map.hbs | 2 +- addon/components/place/details.hbs | 2 +- addon/components/service-area/details.hbs | 2 +- addon/components/zone/details.hbs | 2 +- addon/helpers/leaflet-tile-url.js | 7 ++++++- 6 files changed, 11 insertions(+), 6 deletions(-) diff --git a/addon/components/modals/place-details.hbs b/addon/components/modals/place-details.hbs index 6be51d8a1..ca2f96b78 100644 --- a/addon/components/modals/place-details.hbs +++ b/addon/components/modals/place-details.hbs @@ -3,7 +3,7 @@
- + diff --git a/addon/components/modals/point-map.hbs b/addon/components/modals/point-map.hbs index 308f5e2b7..b756dcf5c 100644 --- a/addon/components/modals/point-map.hbs +++ b/addon/components/modals/point-map.hbs @@ -1,7 +1,7 @@
- + diff --git a/addon/components/place/details.hbs b/addon/components/place/details.hbs index cb2d9e7e4..d2d2a085d 100644 --- a/addon/components/place/details.hbs +++ b/addon/components/place/details.hbs @@ -75,7 +75,7 @@ @zoomControl={{false}} as |layers| > - + - + - + + * * * + * With no arguments it must be invoked in parentheses. A bare + * `@url={{leaflet-tile-url}}` passes the helper by name, which Glimmer refuses + * with "A resolved helper cannot be passed as a named argument" and the whole + * template fails to render. + * * Recomputes automatically when map settings load or change. */ export default class LeafletTileUrlHelper extends Helper {