Add FunctionMetadata to Overload

Summary: We know that an overload is constructed from a series of functions, so it has function metadata. Store this directly on the overload. Right now, we just grab the metadata of the first signature, but once python/typing#1839 is accepted, we'll need to check the metadata for consistency between signatures and grab some of it from the overload implementation.

Reviewed By: stroxler

Differential Revision: D71089700

fbshipit-source-id: 0040a85ee177ade1eaa00cc71f6cbc670f5e2da2

Author: rchen152

pyre2/lib/alt/function.rs

@@ -93,7 +93,10 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
                     acc.split_off_first().0
                 } else {
                     acc.reverse();
-                    Type::Overload(Overload { signatures: acc })
+                    Type::Overload(Overload {
+                        signatures: acc,
+                        metadata: Box::new(first.metadata.clone()),
+                    })
                 }
             } else {
                 ty
@@ -117,7 +120,10 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
                     );
                     defs.split_off_first().0
                 } else {
-                    Type::Overload(Overload { signatures: defs })
+                    Type::Overload(Overload {
+                        signatures: defs,
+                        metadata: Box::new(first.metadata.clone()),
+                    })
                 }
             } else {
                 first.ty.clone()
@@ -372,22 +378,23 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
             defining_cls.as_ref().map(|cls| cls.name()),
             &def.name.id,
         );
+        let metadata = FuncMetadata {
+            kind,
+            flags: FuncFlags {
+                is_overload,
+                is_staticmethod,
+                is_classmethod,
+                is_property_getter,
+                is_property_setter_with_getter,
+                has_enum_member_decoration,
+                is_override,
+            },
+        };
         let mut ty = Forall::new_type(
             self.type_params(def.range, tparams, errors),
             ForallType::Function(Function {
                 signature: callable,
-                metadata: FuncMetadata {
-                    kind,
-                    flags: FuncFlags {
-                        is_overload,
-                        is_staticmethod,
-                        is_classmethod,
-                        is_property_getter,
-                        is_property_setter_with_getter,
-                        has_enum_member_decoration,
-                        is_override,
-                    },
-                },
+                metadata: metadata.clone(),
             }),
         );
         for x in decorators.into_iter().rev() {
@@ -396,6 +403,7 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
         Arc::new(DecoratedFunction {
             id_range: def.name.range,
             ty,
+            metadata,
             is_overload,
         })
     }

pyre2/lib/alt/types/decorated_function.rs

@@ -9,8 +9,14 @@ use std::fmt;
 use std::fmt::Debug;
 use std::fmt::Display;
 
+use ruff_python_ast::name::Name;
 use ruff_text_size::TextRange;
 
+use crate::module::module_name::ModuleName;
+use crate::types::callable::FuncFlags;
+use crate::types::callable::FuncId;
+use crate::types::callable::FuncMetadata;
+use crate::types::callable::FunctionKind;
 use crate::types::types::Type;
 
 /// The type of a function definition after decorators are applied. Metadata arising from the
@@ -20,6 +26,7 @@ use crate::types::types::Type;
 pub struct DecoratedFunction {
     pub id_range: TextRange,
     pub ty: Type,
+    pub metadata: FuncMetadata,
     pub is_overload: bool,
 }
 
@@ -34,6 +41,14 @@ impl DecoratedFunction {
         DecoratedFunction {
             id_range: TextRange::default(),
             ty: Type::any_implicit(),
+            metadata: FuncMetadata {
+                kind: FunctionKind::Def(Box::new(FuncId {
+                    module: ModuleName::default(),
+                    cls: None,
+                    func: Name::default(),
+                })),
+                flags: FuncFlags::default(),
+            },
             is_overload: false,
         }
     }

pyre2/lib/types/types.rs

@@ -324,6 +324,7 @@ impl BoundMethodType {
 #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub struct Overload {
     pub signatures: Vec1<Type>,
+    pub metadata: Box<FuncMetadata>,
 }
 
 impl Overload {
@@ -620,7 +621,12 @@ impl Type {
                 .signatures
                 .try_mapped_ref(|x| x.to_unbound_callable().ok_or(()))
                 .ok()
-                .map(|signatures| Type::Overload(Overload { signatures })),
+                .map(|signatures| {
+                    Type::Overload(Overload {
+                        signatures,
+                        metadata: overload.metadata.clone(),
+                    })
+                }),
             _ => None,
         }
     }