Skip to content

Commit f56b7a6

Browse files
committed
Some Colors and Fonts entries already provide user facing descriptions
via ThemeElementCategory, while others do not. This change uses the existing descriptions to display in the description box and adds description for ones that doesn't have any entries to ensure the description area is not left empty and that available descriptions are consistently utilised. The main change pertaining to this has been merged in eclipse.platform.ui and eclipse.platform via eclipse-platform/eclipse.platform.ui#3666 and eclipse-platform/eclipse.platform#2453 respectively. One of the remaining part pertaining to the above PR's are addressed via this change.
1 parent 00b9e96 commit f56b7a6

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

org.eclipse.jdt.ui/plugin.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ ModuleInfoClassFileViewerName=Module-Info Class File Viewer
155155
javaEditorFontDefiniton.label= Java Editor Text Font
156156
javaEditorFontDefintion.description= The Java editor text font is used by Java editors.
157157

158+
JavaTheme.description= Colors and fonts used in the Java editor, Javadoc and Java views.
159+
158160
javaCompareFontDefiniton.label= Java compare text font
159161
javaCompareFontDefiniton.description= The Java compare text font is used by Java compare/merge tools.
160162

org.eclipse.jdt.ui/plugin.xml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,9 +1190,14 @@
11901190
class="org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider"/>
11911191
</extension>
11921192

1193-
<extension
1194-
point="org.eclipse.ui.themes">
1195-
<themeElementCategory label="%javaPresentation.label" id="org.eclipse.jdt.ui.presentation"/>
1193+
<extension point="org.eclipse.ui.themes">
1194+
<themeElementCategory
1195+
label="%javaPresentation.label"
1196+
id="org.eclipse.jdt.ui.presentation">
1197+
<description>
1198+
%JavaTheme.description
1199+
</description>
1200+
</themeElementCategory>
11961201
<fontDefinition
11971202
label="%javaEditorFontDefiniton.label"
11981203
defaultsTo="org.eclipse.jface.textfont"

0 commit comments

Comments
 (0)