Fix OnBottom case

Author: ShahzaibIbrahim

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java

@@ -631,10 +631,10 @@ void drawSelectedTab(int itemIndex, GC gc, Rectangle bounds) {
 				highlightOnTop = !highlightOnTop;
 			}
 
-			if (highlightOnTop && cornerSize != SQUARE_CORNER) {
+			if (highlightOnTop != onBottom && cornerSize != SQUARE_CORNER) {
 				// When using round tabs, extract the part of the outline that covers the
 				// highlight and draw it with adapted height
-				int[] highlightShape = Arrays.copyOfRange(tabOutlinePoints, 12, tabOutlinePoints.length - 12);
+				int[] highlightShape = Arrays.copyOfRange(tabOutlinePoints, 14, tabOutlinePoints.length - 14);
 				int yEnd = !highlightOnTop
 						? outlineBoundsForOutline.y + outlineBoundsForOutline.height - highlightHeight + 1
 						: highlightHeight;
@@ -647,9 +647,9 @@ void drawSelectedTab(int itemIndex, GC gc, Rectangle bounds) {
 				// When using square tab or drawing the highlight at the bottom, simply draw a
 				// line
 				int highlightY = highlightOnTop ? outlineBoundsForOutline.y
-						: bounds.y + bounds.height - highlightHeight + 1;
+						: bounds.y + bounds.height - highlightHeight + (!onBottom ? 1 : 0);
 				gc.fillRectangle(outlineBoundsForOutline.x, highlightY, outlineBoundsForOutline.width, highlightHeight);
-				if (highlightOnTop) {
+				if (highlightOnTop && !onBottom) {
 					// Compensate for the outline being draw on top of the filled region by
 					// extending the highlight with an equally wide line next to the filled region
 					gc.setLineWidth(1);