Skip to content

Commit 72b35dc

Browse files
committed
Address feedback
1 parent 88ddeef commit 72b35dc

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

build-tools/scripts/Ndk.projitems.in

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<AndroidNdkApiLevel_X86 Condition=" '$(AndroidNdkApiLevel_X86)' == '' ">@NDK_X86_API_NET@</AndroidNdkApiLevel_X86>
1212
<AndroidNdkApiLevel_X86_64 Condition=" '$(AndroidNdkApiLevel_X86_64)' == '' ">@NDK_X86_64_API@</AndroidNdkApiLevel_X86_64>
1313
<AndroidNdkApiLevel_X64 Condition=" '$(AndroidNdkApiLevel_X64)' == '' ">@NDK_X86_64_API_NET@</AndroidNdkApiLevel_X64>
14-
<AndroidNdkAPiLevelNonMono_Arm64 Condition=" '$(AndroidNdkAPiLevelNonMono_Arm64)' == '' ">@NDK_ARM64_V8A_API_NON_MONO@</AndroidNdkAPiLevelNonMono_Arm64>
15-
<AndroidNdkAPiLevelNonMono_X64 Condition=" '$(AndroidNdkAPiLevelNonMono_X64)' == '' ">@NDK_X86_64_API_NON_MONO@</AndroidNdkAPiLevelNonMono_X64>
14+
<AndroidNdkApiLevelNonMono_Arm64 Condition=" '$(AndroidNdkApiLevelNonMono_Arm64)' == '' ">@NDK_ARM64_V8A_API_NON_MONO@</AndroidNdkApiLevelNonMono_Arm64>
15+
<AndroidNdkApiLevelNonMono_X64 Condition=" '$(AndroidNdkApiLevelNonMono_X64)' == '' ">@NDK_X86_64_API_NON_MONO@</AndroidNdkApiLevelNonMono_X64>
1616
</PropertyGroup>
1717

1818
<ItemGroup>
@@ -32,7 +32,7 @@
3232
Condition=" $(AndroidSupportedTargetJitAbisForConditionalChecks.Contains (':arm64-v8a:')) ">
3333
<ApiLevel>$(AndroidNdkApiLevel_ArmV8a)</ApiLevel>
3434
<ApiLevelNET>$(AndroidNdkApiLevel_Arm64)</ApiLevelNET>
35-
<ApiLevelNonMono>$(AndroidNdkAPiLevelNonMono_Arm64)</ApiLevelNonMono>
35+
<ApiLevelNonMono>$(AndroidNdkApiLevelNonMono_Arm64)</ApiLevelNonMono>
3636
<AndroidRID>android-arm64</AndroidRID>
3737
<SupportMonoVM>True</SupportMonoVM>
3838
<SupportCoreCLR>True</SupportCoreCLR>
@@ -55,7 +55,7 @@
5555
Condition=" $(AndroidSupportedTargetJitAbisForConditionalChecks.Contains (':x86_64:')) ">
5656
<ApiLevel>$(AndroidNdkApiLevel_X86_64)</ApiLevel>
5757
<ApiLevelNET>$(AndroidNdkApiLevel_X64)</ApiLevelNET>
58-
<ApiLevelNonMono>$(AndroidNdkAPiLevelNonMono_X64)</ApiLevelNonMono>
58+
<ApiLevelNonMono>$(AndroidNdkApiLevelNonMono_X64)</ApiLevelNonMono>
5959
<AndroidRID>android-x64</AndroidRID>
6060
<SupportMonoVM>True</SupportMonoVM>
6161
<SupportCoreCLR>True</SupportCoreCLR>

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,10 @@
150150
<!-- <_XACommonPropsReplacement Include="@NDK_PKG_REVISION@=$(AndroidNdkPkgRevision)" /> -->
151151
<_XACommonPropsReplacement Include="@NDK_PKG_REVISION@=26.3.11579264" />
152152
<_XACommonPropsReplacement Include="@NDK_ARM64_V8A_API@=$(AndroidNdkApiLevel_ArmV8a)" />
153-
<_XACommonPropsReplacement Include="@NDK_ARM64_V8A_API_NON_MONO@=$(AndroidNdkAPiLevelNonMono_Arm64)" />
153+
<_XACommonPropsReplacement Include="@NDK_ARM64_V8A_API_NON_MONO@=$(AndroidNdkApiLevelNonMono_Arm64)" />
154154
<_XACommonPropsReplacement Include="@NDK_ARMEABI_V7_API@=$(AndroidNdkApiLevel_ArmV7a)" />
155155
<_XACommonPropsReplacement Include="@NDK_X86_64_API@=$(AndroidNdkApiLevel_X86_64)" />
156-
<_XACommonPropsReplacement Include="@NDK_X86_64_API_NON_MONO@=$(AndroidNdkAPiLevelNonMono_X64)" />
156+
<_XACommonPropsReplacement Include="@NDK_X86_64_API_NON_MONO@=$(AndroidNdkApiLevelNonMono_X64)" />
157157
<_XACommonPropsReplacement Include="@NDK_X86_API@=$(AndroidNdkApiLevel_X86)" />
158158
<_XACommonPropsReplacement Include="@PACKAGE_VERSION_BUILD@=$(XAVersionCommitCount)" />
159159
<_XACommonPropsReplacement Include="@PACKAGE_VERSION@=$(ProductVersion)" />

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.props.in

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,25 @@
3535
<ResolveAssemblyConflicts>true</ResolveAssemblyConflicts>
3636

3737
<AndroidNdkApiLevel_Arm64>@NDK_ARM64_V8A_API_NON_MONO@</AndroidNdkApiLevel_Arm64>
38-
<AndroidNdkAPiLevel_X64>@NDK_X86_64_API_NON_MONO@</AndroidNdkAPiLevel_X64>
38+
<AndroidNdkApiLevel_X64>@NDK_X86_64_API_NON_MONO@</AndroidNdkApiLevel_X64>
3939
</PropertyGroup>
4040
<ItemGroup>
4141
<AndroidMinimumSupportedApiLevel Include="armeabi-v7a">
4242
<ApiLevel>@NDK_ARMEABI_V7_API@</ApiLevel>
4343
</AndroidMinimumSupportedApiLevel>
44-
<AndroidMinimumSupportedApiLevel Include="arm64-v8a" Condition=" '$(AndroidRuntime)' == 'Mono' ">
44+
<AndroidMinimumSupportedApiLevel Include="arm64-v8a" Condition=" '$(_AndroidRuntime)' == 'Mono' ">
4545
<ApiLevel>@NDK_ARM64_V8A_API@</ApiLevel>
4646
</AndroidMinimumSupportedApiLevel>
47-
<AndroidMinimumSupportedApiLevel Include="arm64-v8a" Condition=" '$(AndroidRuntime)' != 'Mono' ">
47+
<AndroidMinimumSupportedApiLevel Include="arm64-v8a" Condition=" '$(_AndroidRuntime)' != 'Mono' ">
4848
<ApiLevel>@NDK_ARM64_V8A_API_NON_MONO@</ApiLevel>
4949
</AndroidMinimumSupportedApiLevel>
5050
<AndroidMinimumSupportedApiLevel Include="x86">
5151
<ApiLevel>@NDK_X86_API@</ApiLevel>
5252
</AndroidMinimumSupportedApiLevel>
53-
<AndroidMinimumSupportedApiLevel Include="x86_64" Condition=" '$(AndroidRuntime)' == 'Mono' ">
53+
<AndroidMinimumSupportedApiLevel Include="x86_64" Condition=" '$(_AndroidRuntime)' == 'Mono' ">
5454
<ApiLevel>@NDK_X86_64_API@</ApiLevel>
5555
</AndroidMinimumSupportedApiLevel>
56-
<AndroidMinimumSupportedApiLevel Include="x86_64" Condition=" '$(AndroidRuntime)' != 'Mono' ">
56+
<AndroidMinimumSupportedApiLevel Include="x86_64" Condition=" '$(_AndroidRuntime)' != 'Mono' ">
5757
<ApiLevel>@NDK_X86_64_API_NON_MONO@</ApiLevel>
5858
</AndroidMinimumSupportedApiLevel>
5959
</ItemGroup>

0 commit comments

Comments
 (0)