Skip to content

bugs: ABI incompatibility after 1.5.0 release #47

Description

@ycexiao

Problems

It is from diffpy/diffpy.srreal#85

yes. Libdiffpy has been changed to be compatible with nanobind. We need to think a bit about this because this may not be backwards compatible so we need to make sure that everything works. If someone installs a version of srreal that uses boost then it needs to load the old version of libdiffpy but if it loads a version of srreal that uses nanobind, it loads the new version. Please could we look into how to handle that elegantly?

Solution

There is a closely related FAQ in the Conda-forge documentation How to handle breaking of a package due to ABI incompatibility?

In summary:

  • update the setup.py in the diffpy.srreal.
  • Hot-fix the published version of diffpy.srreal to pin the version of libdiffpy by Repodata patching
  • Add run_export in libdiffpy's meta.yaml in the next release
    If we plan to add libdiffpy to conda-forge-pinning, create PR to Conda-forge-pinning-feedstock

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions