Commit 6a05f3b
Adjust pp_file as an unnessary parameter in save to abacus/stru (#752)
In case, some one may just save only as a stru file and has no
pseudopotential information.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved error handling and messaging for cases where the pseudo
potential file is not provided.
- Added checks to ensure parameter lengths match the total number of
atoms, enhancing robustness.
- **New Features**
- Introduced a default value for the pseudo potential file parameter,
allowing for more flexible function usage.
- **Tests**
- Added a new test to verify functionality when the pseudo potential
file is not specified, ensuring reliable output with minimal parameters.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: root <pxlxingliang>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>1 parent 7c9be86 commit 6a05f3b
2 files changed
Lines changed: 21 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
635 | 635 | | |
636 | 636 | | |
637 | 637 | | |
638 | | - | |
| 638 | + | |
639 | 639 | | |
640 | 640 | | |
641 | 641 | | |
| |||
759 | 759 | | |
760 | 760 | | |
761 | 761 | | |
762 | | - | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
763 | 771 | | |
764 | 772 | | |
765 | 773 | | |
| |||
771 | 779 | | |
772 | 780 | | |
773 | 781 | | |
774 | | - | |
775 | | - | |
776 | | - | |
777 | | - | |
778 | | - | |
779 | | - | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
780 | 789 | | |
781 | 790 | | |
782 | 791 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
0 commit comments