Commit 9eabf93
committed
docs: address code review findings and add PR references
Brainstorm: add PR #166 (Agent plugin) and PR #200 (Vector Search
plugin) as future extension references. Rename future enhancement
section to cover both Vector Search and Lakebase pgvector options.
Plan: address findings from multi-agent code review (architecture,
security, performance, spec flow, pattern recognition):
- Fix cache infrastructure: use shared CacheManager pool, not
fictional maxEntries config
- Clarify error contract: programmatic API errors propagate,
HTTP handlers use execute() for interceptors
- Separate _chatCollect()/_embed() from HTTP handlers
- Add SSE buffer max size (1MB) to prevent OOM
- Restrict response_format to text/json_object (no json_schema v1)
- Add runtime role validation against known set
- Add model to parameter allowlist for Foundation Model API
- Add stop parameter bounds (4 entries, 256 chars)
- Standardize connection pool at 100 (was contradictory 50/100)
- Add retry on 503 for chatCollect() (cold-start resilience)
- Specify setup() throws on missing endpoint, shutdown() cleanup
- Extract SSE parser to stream/sse-parser.ts in Phase 2
- Add per-route body-parser middleware (not global)
- Update acceptance criteria and security checklist
Signed-off-by: Pawel Kosiec <pawel.kosiec@databricks.com>1 parent 5423cd8 commit 9eabf93
File tree
2 files changed
+68
-33
lines changed- docs
- brainstorms
- plans
2 files changed
+68
-33
lines changedLines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
159 | 161 | | |
160 | 162 | | |
161 | 163 | | |
| |||
169 | 171 | | |
170 | 172 | | |
171 | 173 | | |
| 174 | + | |
| 175 | + | |
0 commit comments