Skip to content

Commit f4b1d55

Browse files
fhacloidclaude
andcommitted
refactor(cyargs): extract --url flag into cyargs for plugin commands
Three plugin commands defined --url inline without going through cyargs. Consolidate into AddURLFlag/GetURL in cyargs/plugins.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 58c8937 commit f4b1d55

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed

cmd/cycloid/beta/plugins/manager/create.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func NewCreateCommand() *cobra.Command {
2323
}
2424

2525
cmd.MarkFlagRequired(cyargs.AddNameFlag(cmd))
26-
cmd.Flags().String("url", "", "URL of the plugin manager instance (required)")
26+
cyargs.AddURLFlag(cmd, "URL of the plugin manager instance (required)")
2727
cmd.MarkFlagRequired("url")
2828
return cmd
2929
}
@@ -42,7 +42,7 @@ func createPluginManager(cmd *cobra.Command, args []string) error {
4242
return err
4343
}
4444

45-
url, err := cmd.Flags().GetString("url")
45+
url, err := cyargs.GetURL(cmd)
4646
if err != nil {
4747
return errors.Wrap(err, "unable to get --url flag")
4848
}

cmd/cycloid/beta/plugins/registry/add.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func NewAddCommand() *cobra.Command {
2323
}
2424

2525
cmd.MarkFlagRequired(cyargs.AddNameFlag(cmd))
26-
cmd.Flags().String("url", "", "URL of the plugin registry (required)")
26+
cyargs.AddURLFlag(cmd, "URL of the plugin registry (required)")
2727
cmd.MarkFlagRequired("url")
2828
return cmd
2929
}
@@ -42,7 +42,7 @@ func addPluginRegistry(cmd *cobra.Command, args []string) error {
4242
return err
4343
}
4444

45-
url, err := cmd.Flags().GetString("url")
45+
url, err := cyargs.GetURL(cmd)
4646
if err != nil {
4747
return errors.Wrap(err, "unable to get --url flag")
4848
}

cmd/cycloid/beta/plugins/registry/plugin/version/publish.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func NewPublishCommand() *cobra.Command {
2323
RunE: publishVersion,
2424
}
2525

26-
cmd.Flags().String("url", "", "URL of the plugin version archive (required)")
26+
cyargs.AddURLFlag(cmd, "URL of the plugin version archive (required)")
2727
cmd.MarkFlagRequired("url")
2828
return cmd
2929
}
@@ -42,7 +42,7 @@ func publishVersion(cmd *cobra.Command, args []string) error {
4242
return err
4343
}
4444

45-
url, err := cmd.Flags().GetString("url")
45+
url, err := cyargs.GetURL(cmd)
4646
if err != nil {
4747
return errors.Wrap(err, "unable to get --url flag")
4848
}

internal/cyargs/plugins.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,20 @@ import (
1414
"github.com/cycloidio/cycloid-cli/cmd/cycloid/middleware"
1515
)
1616

17+
// ---------------------------------------------------------------------------
18+
// URL flag (registry add, manager create, version publish)
19+
// ---------------------------------------------------------------------------
20+
21+
// AddURLFlag registers a --url flag with the given usage description.
22+
func AddURLFlag(cmd *cobra.Command, usage string) {
23+
cmd.Flags().String("url", "", usage)
24+
}
25+
26+
// GetURL returns the value of the --url flag.
27+
func GetURL(cmd *cobra.Command) (string, error) {
28+
return cmd.Flags().GetString("url")
29+
}
30+
1731
// ---------------------------------------------------------------------------
1832
// Plugin config flags (for install / upgrade)
1933
// ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)