Apply some ideas of code review

Knerio · Knerio · commit 8719635db157 · 2026-04-11T17:49:09.000+02:00
diff --git a/ts/examples/simple-example-ts/example.env b/ts/examples/simple-example-ts/example.env
@@ -0,0 +1,4 @@
+AUTH_TOKEN=your_auth_token_here
+AQUILA_URL=https://127.0.0.1:8000
+ACTION_ID=your_action_id_here
+VERSION=0.0.0
diff --git a/ts/examples/simple-example-ts/index.ts b/ts/examples/simple-example-ts/index.ts
diff --git a/ts/examples/simple-example-ts/package-lock.json b/ts/examples/simple-example-ts/package-lock.json
diff --git a/ts/examples/simple-example-ts/src/exampleDataType.ts b/ts/examples/simple-example-ts/src/exampleDataType.ts
@@ -0,0 +1,6 @@
+import {HerculesDataType} from "@code0-tech/hercules";
+
+export const someDataType: HerculesDataType = {
+    identifier: "SOME_DATATYPE",
+    type: "any",
+}
diff --git a/ts/examples/simple-example-ts/src/exampleEventType.ts b/ts/examples/simple-example-ts/src/exampleEventType.ts
@@ -0,0 +1,7 @@
+import {HerculesEventType} from "@code0-tech/hercules"
+
+export const someEventType: HerculesEventType = {
+    signature: "(): string",
+    editable: false,
+    identifier: "test_flow",
+}
diff --git a/ts/examples/simple-example-ts/src/fibonacciFunction.ts b/ts/examples/simple-example-ts/src/fibonacciFunction.ts
@@ -0,0 +1,23 @@
+import {HerculesFunctionContext, Identifier, RuntimeParameter, Signature} from "@code0-tech/hercules";
+
+@Identifier("fib")
+@Signature("(number: number): number")
+@RuntimeParameter({
+    runtimeName: "number",
+    defaultValue: 20
+})
+export class FibonacciFunction {
+    run(context: HerculesFunctionContext, number: number): number {
+        console.log(context)
+        console.log("Project id:", context.projectId);
+        console.log("Execution id:", context.executionId);
+        console.log("Matched configs:", context.matchedConfig); // matched configs for the current execution
+
+        function fibonacci(num: number): number {
+            if (num <= 1) return num;
+            return fibonacci(num - 1) + fibonacci(num - 2);
+        }
+
+        return fibonacci(number)
+    }
+}
diff --git a/ts/examples/simple-example-ts/src/index.ts b/ts/examples/simple-example-ts/src/index.ts
@@ -0,0 +1,44 @@
+import {createSdk, HerculesActionProjectConfiguration} from "@code0-tech/hercules";
+import {FibonacciFunction} from "./fibonacciFunction";
+import {someEventType} from "./exampleEventType";
+import {someDataType} from "./exampleDataType";
+
+const sdk = createSdk({
+    authToken: process.env.AUTH_TOKEN || "token",
+    aquilaUrl: process.env.AQUILA_URL || "127.0.0.1:8081",
+    actionId: process.env.ACTION_ID || "example",
+    version: process.env.VERSION || "0.0.0",
+}, [
+    {
+        type: "string[]",
+        identifier: "EXAMPLE_CONFIG_IDENTIFIER",
+    }
+])
+
+sdk.registerDataTypes(someDataType)
+sdk.registerRuntimeFunctionDefinitionClass(FibonacciFunction)
+sdk.registerEventTypes(someEventType)
+
+
+connectToSdk();
+
+function connectToSdk() {
+    sdk.connect().then((configs: HerculesActionProjectConfiguration[]) => {
+        console.log("SDK connected successfully");
+
+        sdk.dispatchEvent("test_flow", configs[0].projectId, "Hello, World! Configs loaded: " + configs.length).then(() => {
+            console.log("Event dispatched successfully");
+        })
+    }).catch(() => {
+        // will be handled by logger internally
+        process.exit(1)
+    })
+
+    sdk.onError((error) => {
+        console.error("SDK Error occurred:", error.message);
+        console.log("Attempting to reconnect in 5s...");
+        setTimeout(() => {
+            connectToSdk();
+        }, 5000)
+    })
+}
diff --git a/ts/examples/simple-example-ts/tsconfig.json b/ts/examples/simple-example-ts/tsconfig.json
@@ -17,6 +17,6 @@
     "types": ["vite/client"]
   },
   "include": [
-    "index.ts"
+    "src/index.ts"
   ]
 }
diff --git a/ts/examples/simple-example-ts/vite.config.ts b/ts/examples/simple-example-ts/vite.config.ts
@@ -4,7 +4,7 @@ import { resolve } from 'path';
 export default defineConfig({
     build: {
         target: "node18",
-        ssr: resolve(__dirname, 'index.ts'), // ✅ correct SSR entry
+        ssr: resolve(__dirname, 'src/index.ts'),
         rollupOptions: {
             external: (id) =>
                 [
diff --git a/ts/src/action_sdk.ts b/ts/src/action_sdk.ts
@@ -5,7 +5,7 @@ import {ActionTransferServiceClient, TransferRequest} from "@code0-tech/tucana/a
 import {FlowTypeSetting,} from "@code0-tech/tucana/shared";
 import {constructValue, toAllowedValue} from "@code0-tech/tucana/helpers";
 import 'reflect-metadata';
-import {connect as connectHelper} from "./sdk/connection/connection";
+import {connect} from "./sdk/connection/connection";
 import {registerFunctionDefinitionClass} from "./sdk/builder/registerFunctionDefinitionClass";
 import {registerRuntimeFunctionDefinitionClass} from "./builder/registerRuntimeFunctionDefinitionClass";
 
@@ -52,7 +52,7 @@ const createSdk = (config: ActionSdk["config"], configDefinitions?: HerculesActi
             state.stream?.responses.onError(handler)
         },
         connect: options => {
-            return connectHelper(state, config, options);
+            return connect(state, config, options);
         },
         getProjectActionConfigurations: () => {
             return state.projectConfigurations.map(value => {
@@ -97,14 +97,14 @@ const createSdk = (config: ActionSdk["config"], configDefinitions?: HerculesActi
                     linkedDataTypeIdentifiers: dataType.linkedDataTypes || [],
                     displayMessage: dataType.displayMessage || [],
                     definitionSource: "action",
-                    version: dataType.version || config.version,
+                    version: config.version,
                 });
             })
 
 
             return Promise.resolve()
         },
-        registerFlowTypes: async (...flowTypes) => {
+        registerEventTypes: async (...flowTypes) => {
             flowTypes.forEach(flowType => {
                 state.flowTypes.push({
                     signature: flowType.signature,
@@ -116,7 +116,7 @@ const createSdk = (config: ActionSdk["config"], configDefinitions?: HerculesActi
                     displayMessage: flowType.displayMessage || [],
                     documentation: flowType.documentation || [],
                     definitionSource: "action",
-                    version: flowType.version || config.version,
+                    version: config.version,
                     linkedDataTypeIdentifiers: flowType.linkedDataTypes || [],
                     settings: (flowType.settings || []).map(setting => ({
                         name: setting.name || [],
@@ -146,7 +146,7 @@ const createSdk = (config: ActionSdk["config"], configDefinitions?: HerculesActi
                         event: {
                             projectId: projectIdBigInt,
                             eventType: eventType,
-                            payload: constructValue(payload) || constructValue(null),
+                            payload: constructValue(payload || null),
                         }
                     }
                 })
@@ -161,5 +161,5 @@ const createSdk = (config: ActionSdk["config"], configDefinitions?: HerculesActi
 
 export {
     createSdk,
-    connectHelper as connect
+    connect
 }
diff --git a/ts/src/sdk/builder/builder.ts b/ts/src/sdk/builder/builder.ts
@@ -20,7 +20,6 @@ export function buildRuntimeFunctionDefinition(klass: RuntimeFunctionDefinitionC
     const documentation: HerculesRuntimeFunctionDefinition["documentation"] = Reflect.getMetadata('hercules:documentation', klass) || []
     const signature: HerculesRuntimeFunctionDefinition["signature"] = Reflect.getMetadata('hercules:signature', klass)
     const linkedDataTypeIdentifiers: HerculesRuntimeFunctionDefinition["linkedDataTypes"] = Reflect.getMetadata('hercules:linked_data_type_identifiers', klass) || []
-    const version: HerculesRuntimeFunctionDefinition["version"] = Reflect.getMetadata('hercules:version', klass) || config.version
     const displayIcon: HerculesRuntimeFunctionDefinition["displayIcon"] = Reflect.getMetadata('hercules:display_icon', klass) || ""
     const throwsError: HerculesRuntimeFunctionDefinition["throwsError"] = Reflect.getMetadata('hercules:throws_error', klass) || false
     const runFunction = new klass().run
@@ -38,7 +37,7 @@ export function buildRuntimeFunctionDefinition(klass: RuntimeFunctionDefinitionC
             alias: alias || [],
             name: names || [],
             description: description || [],
-            version: version || config.version,
+            version: config.version,
             runtimeName: identifier,
             deprecationMessage: deprecationMessage || [],
             displayIcon: displayIcon || "tabler:note",
diff --git a/ts/src/sdk/builder/registerFunctionDefinitionClass.ts b/ts/src/sdk/builder/registerFunctionDefinitionClass.ts
@@ -27,7 +27,6 @@ export function registerFunctionDefinitionClass(config: {
         const documentation: HerculesFunctionDefinition["documentation"] = Reflect.getMetadata('hercules:documentation', klass)
         const signature: HerculesFunctionDefinition["signature"] = Reflect.getMetadata('hercules:signature', klass)
         const linkedDataTypeIdentifiers: HerculesFunctionDefinition["linkedDataTypes"] = Reflect.getMetadata('hercules:linked_data_type_identifiers', klass)
-        const version: HerculesFunctionDefinition["version"] = Reflect.getMetadata('hercules:version', klass)
         const displayIcon: HerculesFunctionDefinition["displayIcon"] = Reflect.getMetadata('hercules:display_icon', klass)
         const throwsError: HerculesFunctionDefinition["throwsError"] = Reflect.getMetadata('hercules:throws_error', klass)
 
@@ -49,7 +48,7 @@ export function registerFunctionDefinitionClass(config: {
                 signature: signature || runtimeDefinition.signature,
                 throwsError: throwsError || runtimeDefinition.throwsError,
                 alias: alias || runtimeDefinition.alias,
-                version: version || runtimeDefinition.version,
+                version: config.version,
                 description: description || runtimeDefinition.description,
                 name: names || runtimeDefinition.name,
                 documentation: documentation || runtimeDefinition.documentation,
diff --git a/ts/src/sdk/connection/connection.ts b/ts/src/sdk/connection/connection.ts
@@ -35,7 +35,7 @@ export async function connect(state: SdkState, config: ActionSdk["config"], opti
 
     return new Promise(async (resolve, reject) => {
         try {
-            for await (let message of state?.stream?.responses || []) {
+            for await (const message of state?.stream?.responses || []) {
                 logger.debug({
                     message: message,
                     config,
diff --git a/ts/src/sdk/execution.ts b/ts/src/sdk/execution.ts
@@ -44,8 +44,7 @@ function buildContext(message: TransferResponse, execution: ExecutionRequest, st
     const params = buildParams(execution, func, message);
 
     let conf = state.projectConfigurations.find(config => {
-        //TODO
-        return true
+        return config.projectId === execution.projectId
     })
 
     if (!conf) {
@@ -97,7 +96,7 @@ export function handleExecutionRequest(state: SdkState, message: TransferRespons
         context
     })
 
-    const funcHandler = (func as any).handler
+    const funcHandler = func.handler
 
     if (funcHandler.length == params.length + 1) {
         // handler has context parameter
@@ -110,14 +109,7 @@ export function handleExecutionRequest(state: SdkState, message: TransferRespons
         return;
     }
 
-    const result = new Promise((resolve, reject) => {
-        try {
-            resolve(funcHandler(...params))
-        } catch (e) {
-            reject(e)
-        }
-    })
-    result.then((value: any) => {
+    Promise.resolve(funcHandler(...params)) .then((value: any) => {
         const request = TransferRequest.create({
             data: {
                 oneofKind: "result",
diff --git a/ts/src/types.ts b/ts/src/types.ts

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,6 @@`
`17`	`17`	`"types": ["vite/client"]`
`18`	`18`	`},`
`19`	`19`	`"include": [`
`20`		`- "index.ts"`
	`20`	`+ "src/index.ts"`
`21`	`21`	`]`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import { resolve } from 'path';`
`4`	`4`	`export default defineConfig({`
`5`	`5`	`build: {`
`6`	`6`	`target: "node18",`
`7`		`- ssr: resolve(__dirname, 'index.ts'), // ✅ correct SSR entry`
	`7`	`+ ssr: resolve(__dirname, 'src/index.ts'),`
`8`	`8`	`rollupOptions: {`
`9`	`9`	`external: (id) =>`
`10`	`10`	`[`