refactor: remove path logic

Author: BioPhoton

packages/utils/src/lib/profiler/wal-json-trace.ts

@@ -98,14 +98,6 @@ export const traceEventWalFormat = <
         JSON.stringify(encodeTraceEvent(event)),
       decode: (json: string) => decodeTraceEvent(JSON.parse(json)) as T,
     },
-    shardPath: (id: string) =>
-      groupId
-        ? `${baseName}.${groupId}.${id}${walExtension}`
-        : `${baseName}.${id}${walExtension}`,
-    finalPath: () =>
-      groupId
-        ? `${baseName}.${groupId}${finalExtension}`
-        : `${baseName}${finalExtension}`,
     finalizer: (
       records: (UserTimingTraceEvent | InvalidEntry<string>)[],
       metadata?: Record<string, unknown>,

packages/utils/src/lib/profiler/wal-json-trace.unit.test.ts

@@ -223,8 +223,6 @@ describe('traceEventWalFormat', () => {
       baseName: 'trace',
       walExtension: '.jsonl',
       finalExtension: '.json',
-      shardPath: expect.any(Function),
-      finalPath: expect.any(Function),
       codec: {
         encode: expect.any(Function),
         decode: expect.any(Function),
@@ -249,36 +247,6 @@ describe('traceEventWalFormat', () => {
     expect(format.finalExtension).toBe('.json');
   });
 
-  it('should generate correct shard paths', () => {
-    const format = traceEventWalFormat();
-
-    expect(format.shardPath('shard-1')).toBe('trace.shard-1.jsonl');
-    expect(format.shardPath('process-123-thread-456')).toBe(
-      'trace.process-123-thread-456.jsonl',
-    );
-  });
-
-  it('should generate correct shard paths with groupId', () => {
-    const format = traceEventWalFormat({ groupId: 'session-123' });
-
-    expect(format.shardPath('shard-1')).toBe('trace.session-123.shard-1.jsonl');
-    expect(format.shardPath('process-123-thread-456')).toBe(
-      'trace.session-123.process-123-thread-456.jsonl',
-    );
-  });
-
-  it('should generate correct final path', () => {
-    const format = traceEventWalFormat();
-
-    expect(format.finalPath()).toBe('trace.json');
-  });
-
-  it('should generate correct final path with groupId', () => {
-    const format = traceEventWalFormat({ groupId: 'session-123' });
-
-    expect(format.finalPath()).toBe('trace.session-123.json');
-  });
-
   it('should encode and decode trace events correctly', () => {
     const format = traceEventWalFormat();
     const testEvent: UserTimingTraceEvent = {

packages/utils/src/lib/wal.ts

@@ -496,5 +496,12 @@ export class ShardedWal<T extends object | string = object> {
         // Directory might not be empty or already removed, ignore
       }
     });
+
+    // Also try to remove the root directory if it becomes empty
+    try {
+      fs.rmdirSync(this.#dir);
+    } catch {
+      // Directory might not be empty or already removed, ignore
+    }
   }
 }