Skip to content

Commit 5b5328e

Browse files
committed
fix: Unblock dependency updates
- Guard null buffer in JSON scalar toString, which @apache-arrow/esnext-esm 21.2.0 rejects (TS2345 on TextDecoder.decode) - Drop redundant Promise.resolve return in sync, flagged by eslint-plugin-unicorn 72 - Hold typescript at <7 until typescript-eslint supports it
1 parent 4b8aea7 commit 5b5328e

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/renovate.json5

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
11
{
22
extends: ["github>cloudquery/.github//.github/renovate-node-default.json5"],
3+
packageRules: [
4+
{
5+
// typescript-eslint does not support TS 7 yet: https://github.com/typescript-eslint/typescript-eslint/issues/10940
6+
matchPackageNames: ["typescript"],
7+
allowedVersions: "<7",
8+
},
9+
],
310
}

src/scalar/json.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class JSONType implements Scalar<Nullable<Uint8Array>> {
7272
}
7373

7474
public toString() {
75-
if (this._valid) {
75+
if (this._valid && this._value !== null) {
7676
return new TextDecoder().decode(this._value);
7777
}
7878

src/scheduler/scheduler.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,5 +269,4 @@ export const sync = async ({
269269
}
270270

271271
stream.end();
272-
return await Promise.resolve();
273272
};

0 commit comments

Comments
 (0)