From 74de13a2a752385d5510cb8e8620ed0a5d15f0ec Mon Sep 17 00:00:00 2001
From: Yannis Moser <yannis.moser@sap.com>
Date: Tue, 3 Mar 2026 16:00:25 +0100
Subject: [PATCH] removed unused function and use array in the workflow api for
 status

---
 lib/api/local-workflow-store.ts | 15 +++++----------
 lib/api/workflow-client.ts      |  7 +++----
 srv/localProcessService.ts      | 10 ++++------
 3 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/lib/api/local-workflow-store.ts b/lib/api/local-workflow-store.ts
index 15d646b..4049c74 100644
--- a/lib/api/local-workflow-store.ts
+++ b/lib/api/local-workflow-store.ts
@@ -64,13 +64,12 @@ export class LocalWorkflowStore {
 
   getInstancesByBusinessKey(
     businessKey: string,
-    status?: WorkflowStatus | WorkflowStatus[],
+    status?: WorkflowStatus[],
   ): LocalWorkflowInstance[] {
     let filtered = this.instances.filter((i) => i.businessKey === businessKey);
 
     if (status) {
-      const statuses = Array.isArray(status) ? status : [status];
-      filtered = filtered.filter((i) => statuses.includes(i.status));
+      filtered = filtered.filter((i) => status.includes(i.status));
     }
 
     return filtered;
@@ -81,7 +80,7 @@ export class LocalWorkflowStore {
   }
 
   updateStatus(instanceId: string, status: WorkflowStatus): UpdateStatusResult {
-    const instance = this.instances.find((i) => i.id === instanceId);
+    const instance = this.getInstance(instanceId);
 
     if (!instance) {
       return {
@@ -104,18 +103,14 @@ export class LocalWorkflowStore {
   }
 
   getAttributes(instanceId: string): Record<string, string>[] | undefined {
-    const instance = this.instances.find((i) => i.id === instanceId);
+    const instance = this.getInstance(instanceId);
     return instance?.attributes;
   }
 
   getOutputs(instanceId: string): Record<string, unknown> | undefined {
-    const instance = this.instances.find((i) => i.id === instanceId);
+    const instance = this.getInstance(instanceId);
     return instance?.outputs;
   }
-
-  clear(): void {
-    this.instances = [];
-  }
 }
 
 export const localWorkflowStore = new LocalWorkflowStore();
diff --git a/lib/api/workflow-client.ts b/lib/api/workflow-client.ts
index e5532a7..50d442a 100644
--- a/lib/api/workflow-client.ts
+++ b/lib/api/workflow-client.ts
@@ -38,7 +38,7 @@ export interface IWorkflowInstanceClient {
 
   getWorkflowsByBusinessKey(
     businessKey: string,
-    status: WorkflowStatus | WorkflowStatus[],
+    status: WorkflowStatus[],
   ): Promise<WorkflowInstance[]>;
 
   updateWorkflowStatus(
@@ -93,13 +93,12 @@ export async function getWorkflowsByBusinessKey(
   serviceUrl: string,
   jwt: string,
   businessKey: string,
-  status: WorkflowStatus | WorkflowStatus[],
+  status: WorkflowStatus[],
 ): Promise<WorkflowInstance[]> {
   const encodedBusinessKey = encodeURIComponent(businessKey);
   let queryUrl = `${serviceUrl}${BASE_PATH}/v1/workflow-instances?businessKey=${encodedBusinessKey}`;
 
-  const statuses = Array.isArray(status) ? status : [status];
-  statuses.forEach((s) => {
+  status.forEach((s) => {
     queryUrl += `&status=${s}`;
   });
   LOG.debug('Invoking url: ' + queryUrl);
diff --git a/srv/localProcessService.ts b/srv/localProcessService.ts
index 4962221..ec2f970 100644
--- a/srv/localProcessService.ts
+++ b/srv/localProcessService.ts
@@ -69,10 +69,9 @@ class ProcessService extends cds.ApplicationService {
           `==============================================================`,
       );
 
-      const instances = localWorkflowStore.getInstancesByBusinessKey(
-        businessKey,
+      const instances = localWorkflowStore.getInstancesByBusinessKey(businessKey, [
         WorkflowStatus.RUNNING,
-      );
+      ]);
 
       if (instances.length === 0) {
         LOG.warn(`No running workflow instances found with businessKey: ${businessKey}`);
@@ -102,10 +101,9 @@ class ProcessService extends cds.ApplicationService {
           `==============================================================`,
       );
 
-      const instances = localWorkflowStore.getInstancesByBusinessKey(
-        businessKey,
+      const instances = localWorkflowStore.getInstancesByBusinessKey(businessKey, [
         WorkflowStatus.SUSPENDED,
-      );
+      ]);
 
       if (instances.length === 0) {
         LOG.warn(`No suspended workflow instances found with businessKey: ${businessKey}`);