Skip to content

chore: update preview workflow #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghostdevv wants to merge 6 commits into
base: main
Choose a base branch
from
+13 −7
Open

chore: update preview workflow #39

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89ceba4
chore: use hashes for versions
ghostdevv May 23, 2026
5d33b52
chore: update node version
ghostdevv May 23, 2026
4428bc9
perf: set concurrency limits to reduce cost and improve dx
ghostdevv May 23, 2026
f71ecae
chore: don't save git credentials
ghostdevv May 23, 2026
279a1b5
chore: mitigate potential template injection
ghostdevv May 23, 2026
a34d256
chore: update ::set-output command to new syntax
ghostdevv May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,24 @@ on: [pull_request]
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
preview:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: checkout
uses: actions/checkout@v4
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
submodules: true
persist-credentials: false

- name: setup deno
uses: denoland/setup-deno@v2
uses: denoland/setup-deno@667a34cdef165d8d2b2e98dde39547c9daac7282 # v2.0.4
with:
deno-version: v2.x

Expand All @@ -26,16 +31,17 @@ jobs:

- name: Get Version
id: vars
run: echo ::set-output name=version::$(git describe --abbrev=0 --tags | sed 's/^v//')-pr+$(git rev-parse HEAD)
run: echo "version=$(git describe --abbrev=0 --tags | sed 's/^v//')-pr+$(git rev-parse HEAD)" >> $GITHUB_OUTPUT

- name: Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.x
registry-url: https://registry.npmjs.com
node-version: 24

- name: Build NPM
run: deno task build:npm ${{steps.vars.outputs.version}}
run: deno task build:npm ${STEPS_VARS_OUTPUTS_VERSION}
env:
STEPS_VARS_OUTPUTS_VERSION: ${{steps.vars.outputs.version}}
Comment on lines +42 to +44
Copy link
Copy Markdown
Collaborator

@jbolda jbolda May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is the reasoning for this change?


- name: Publish Preview Versions
run: npx pkg-pr-new publish './build/npm'
Loading