-
Notifications
You must be signed in to change notification settings - Fork 116
Expand file tree
/
Copy pathmixins.py
More file actions
497 lines (405 loc) · 18.4 KB
/
mixins.py
File metadata and controls
497 lines (405 loc) · 18.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
# -*- coding: utf-8 -*-
from collections import OrderedDict, defaultdict
from typing import List, Tuple
from django.contrib.contenttypes.fields import GenericRelation
from django.contrib.contenttypes.models import ContentType
from django.core.exceptions import FieldDoesNotExist, ObjectDoesNotExist
from django.db.models import (SET_DEFAULT, SET_NULL, OneToOneField,
ProtectedError)
from django.db.models.fields.related import ForeignObjectRel, ManyToManyRel
from django.utils.translation import gettext_lazy as _
from rest_framework import serializers
from rest_framework.exceptions import ValidationError
from rest_framework.validators import UniqueValidator
class NestedOnlySerializerMixin(serializers.ModelSerializer):
"""
Required for all serializers that are nested under BaseNestedModelSerializer.
"""
def save(self, **kwargs):
self._save_kwargs = defaultdict(dict, kwargs)
validated_data = {**self.validated_data, **kwargs}
if self.instance is not None:
self.instance = self.update(self.instance, validated_data)
assert self.instance is not None, (
'`update()` did not return an object instance.'
)
else:
self.instance = self.create(validated_data)
assert self.instance is not None, (
'`create()` did not return an object instance.'
)
return self.instance
class BaseNestedModelSerializer(serializers.ModelSerializer):
def _extract_relations(self, validated_data):
reverse_relations = OrderedDict()
relations = OrderedDict()
# Remove related fields from validated data for future manipulations
for field_name, field in self.fields.items():
if field.read_only:
continue
try:
related_field, direct = self._get_related_field(field)
except FieldDoesNotExist:
continue
if isinstance(field, serializers.ListSerializer) and \
isinstance(field.child, serializers.ModelSerializer):
if field.source not in validated_data:
# Skip field if field is not required
continue
validated_data.pop(field.source)
reverse_relations[field_name] = (
related_field, field.child, field.source)
if isinstance(field, serializers.ModelSerializer):
if field.source not in validated_data:
# Skip field if field is not required
continue
if validated_data.get(field.source) is None:
if direct:
# Don't process null value for direct relations
# Native create/update processes these values
continue
validated_data.pop(field.source)
# Reversed one-to-one looks like direct foreign keys but they
# are reverse relations
if direct:
relations[field_name] = (field, field.source)
else:
reverse_relations[field_name] = (
related_field, field, field.source)
return relations, reverse_relations
def _get_related_field(self, field):
model_class = self.Meta.model
try:
related_field = model_class._meta.get_field(field.source)
except FieldDoesNotExist:
# If `related_name` is not set, field name does not include
# `_set` -> remove it and check again
default_postfix = '_set'
if field.source.endswith(default_postfix):
related_field = model_class._meta.get_field(
field.source[:-len(default_postfix)])
else:
raise
if isinstance(related_field, ForeignObjectRel) and not isinstance(related_field, ManyToManyRel):
return related_field.field, False
return related_field, True
def _get_serializer_for_field(self, field, **kwargs):
kwargs.update({
'context': self.context,
'partial': self.partial if kwargs.get('instance') else False,
})
# if field is a polymorphic serializer
if hasattr(field, '_get_serializer_from_resource_type'):
# get 'real' serializer based on resource type
serializer = field._get_serializer_from_resource_type(
kwargs.get('data').get(field.resource_type_field_name)
)
return serializer.__class__(**kwargs)
else:
return field.__class__(**kwargs)
def _get_generic_lookup(self, instance, related_field):
return {
related_field.content_type_field_name:
ContentType.objects.get_for_model(instance),
related_field.object_id_field_name: instance.pk,
}
def _get_related_pk(self, data, model_class):
pk = data.get('pk') or data.get(model_class._meta.pk.attname)
if pk:
return str(pk)
return None
def _extract_related_pks(self, field, related_data):
model_class = field.Meta.model
pk_list = []
for d in filter(None, related_data):
pk = self._get_related_pk(d, model_class)
if pk:
pk_list.append(pk)
return pk_list
def _prefetch_related_instances(self, field, related_data, field_name, instance):
pk_list = self._extract_related_pks(field, related_data)
try:
related_manager = getattr(instance, field_name)
except ObjectDoesNotExist:
return {}
instances = {
str(related_instance.pk): related_instance
for related_instance in related_manager.filter(pk__in=pk_list)
}
return instances
def update_or_create_reverse_relations(self, instance, reverse_relations):
# Update or create reverse relations:
# many-to-one, many-to-many, reversed one-to-one
for field_name, (related_field, field, field_source) in \
reverse_relations.items():
# Skip processing for empty data or not-specified field.
# The field can be defined in validated_data but isn't defined
# in initial_data (for example, if multipart form data used)
related_data = self.get_initial().get(field_name, None)
if related_data is None:
continue
related_validated_data = self._validated_data[field_source]
if related_field.one_to_one:
# If an object already exists, fill in the pk so
# we don't try to duplicate it
pk_name = field.Meta.model._meta.pk.attname
if pk_name not in related_data and 'pk' in related_data:
pk_name = 'pk'
if pk_name not in related_data:
related_instance = getattr(instance, field_source, None)
if related_instance:
related_data[pk_name] = related_instance.pk
# Expand to array of one item for one-to-one for uniformity
related_data = [related_data]
related_validated_data = [related_validated_data]
instances = self._prefetch_related_instances(
field,
related_data,
field_name,
instance
)
save_kwargs = self._get_save_kwargs(field_name)
if isinstance(related_field, GenericRelation):
save_kwargs.update(
self._get_generic_lookup(instance, related_field),
)
elif not related_field.many_to_many:
save_kwargs[related_field.name] = instance
new_related_instances = []
errors = []
for index, data in enumerate(related_data):
obj = instances.get(
self._get_related_pk(data, field.Meta.model)
)
serializer = self._get_serializer_for_field(
field,
instance=obj,
data=data,
)
try:
serializer._errors = {}
serializer._validated_data = related_validated_data[index]
related_instance = serializer.save(**save_kwargs)
data['pk'] = related_instance.pk
new_related_instances.append(related_instance)
errors.append({})
except ValidationError as exc:
errors.append(exc.detail)
if any(errors):
if related_field.one_to_one:
raise ValidationError({field_name: errors[0]})
else:
raise ValidationError({field_name: errors})
if related_field.many_to_many:
# Add m2m instances to through model via add
m2m_manager = getattr(instance, field_source)
m2m_manager.add(*new_related_instances)
def update_or_create_direct_relations(self, attrs, relations):
for field_name, (field, field_source) in relations.items():
obj = None
data = self.get_initial()[field_name]
model_class = field.Meta.model
pk = self._get_related_pk(data, model_class)
# pk needs to be specified if it's not one to one or creation of new object is not intended
is_one_to_one = isinstance(self.Meta.model._meta.get_field(field_source), OneToOneField)
if pk and not is_one_to_one:
# for direct ForeignKey
# potential filtering should be done in the child serializer
# as it is too project-specific
obj = model_class.objects.filter(
pk=pk,
).first()
else:
# for direct OneToOne or current ForeignKey
obj = getattr(self.instance, field_source, None)
serializer = self._get_serializer_for_field(
field,
instance=obj,
data=data,
)
try:
serializer._errors = {}
serializer._validated_data = self._validated_data[field_source]
attrs[field_source] = serializer.save(
**self._get_save_kwargs(field_name)
)
except ValidationError as exc:
raise ValidationError({field_name: exc.detail})
def save(self, **kwargs):
self._save_kwargs = defaultdict(dict, kwargs)
return super(BaseNestedModelSerializer, self).save(**kwargs)
def _get_save_kwargs(self, field_name):
save_kwargs = self._save_kwargs[field_name]
if not isinstance(save_kwargs, dict):
raise TypeError(
_("Arguments to nested serializer's `save` must be dict's")
)
return save_kwargs
class NestedCreateMixin(BaseNestedModelSerializer):
"""
Adds nested create feature
"""
def create(self, validated_data):
relations, reverse_relations = self._extract_relations(validated_data)
# Create or update direct relations (foreign key, one-to-one)
self.update_or_create_direct_relations(
validated_data,
relations,
)
# Create instance
instance = super(NestedCreateMixin, self).create(validated_data)
self.update_or_create_reverse_relations(instance, reverse_relations)
return instance
class NestedUpdateMixin(BaseNestedModelSerializer):
"""
Adds update nested feature
"""
default_error_messages = {
'cannot_delete_protected': _(
"Cannot delete {instances} because "
"protected relation exists")
}
def update(self, instance, validated_data):
relations, reverse_relations = self._extract_relations(validated_data)
# Create or update direct relations (foreign key, one-to-one)
self.update_or_create_direct_relations(
validated_data,
relations,
)
# Update instance
instance = super(NestedUpdateMixin, self).update(
instance,
validated_data,
)
self.update_or_create_reverse_relations(instance, reverse_relations)
self.delete_reverse_relations_if_need(instance, reverse_relations)
instance.refresh_from_db()
return instance
def perform_nested_delete_or_update(self, pks_to_delete, model_class, instance, related_field, field_source):
if related_field.many_to_many:
# Remove relations from m2m table
m2m_manager = getattr(instance, field_source)
m2m_manager.remove(*pks_to_delete)
else:
qs = model_class.objects.filter(pk__in=pks_to_delete)
on_delete = related_field.remote_field.on_delete
if on_delete in (SET_NULL, SET_DEFAULT):
# TODO: handle on_delete.SET() ?
if on_delete == SET_DEFAULT:
default = related_field.get_default()
else:
default = None
qs.update(**{related_field.name: default})
else:
qs.delete()
def delete_reverse_relations_if_need(self, instance, reverse_relations):
if self.partial:
# bypass deletion if set to partial update
return
# Reverse `reverse_relations` for correct delete priority
reverse_relations = OrderedDict(
reversed(list(reverse_relations.items())))
# Delete instances which is missed in data
for field_name, (related_field, field, field_source) in \
reverse_relations.items():
model_class = field.Meta.model
related_data = self.get_initial()[field_name]
# Expand to array of one item for one-to-one for uniformity
if related_field.one_to_one:
related_data = [related_data]
# M2M relation can be as direct or as reverse. For direct relation
# we should use reverse relation name
if related_field.many_to_many:
related_field_lookup = {
related_field.remote_field.name: instance,
}
elif isinstance(related_field, GenericRelation):
related_field_lookup = \
self._get_generic_lookup(instance, related_field)
else:
related_field_lookup = {
related_field.name: instance,
}
current_ids = self._extract_related_pks(field, related_data)
try:
pks_to_delete = list(
model_class.objects.filter(
**related_field_lookup
).exclude(
pk__in=current_ids
).values_list('pk', flat=True)
)
self.perform_nested_delete_or_update(
pks_to_delete,
model_class,
instance,
related_field,
field_source
)
except ProtectedError as e:
instances = e.args[1]
self.fail('cannot_delete_protected', instances=", ".join([
str(instance) for instance in instances]))
class UniqueFieldsMixin(serializers.ModelSerializer):
"""
Moves `UniqueValidator`'s from the validation stage to the save stage.
It solves the problem with nested validation for unique fields on update.
If you want more details, you can read related issues and articles:
https://github.com/beda-software/drf-writable-nested/issues/1
http://www.django-rest-framework.org/api-guide/validators/#updating-nested-serializers
Example of usage:
```
class Child(models.Model):
field = models.CharField(unique=True)
class Parent(models.Model):
child = models.ForeignKey('Child')
class ChildSerializer(UniqueFieldsMixin, serializers.ModelSerializer):
class Meta:
model = Child
class ParentSerializer(NestedUpdateMixin, serializers.ModelSerializer):
child = ChildSerializer()
class Meta:
model = Parent
```
Note: `UniqueFieldsMixin` must be applied only on the serializer
which has unique fields.
Note: When you are using both mixins
(`UniqueFieldsMixin` and `NestedCreateMixin` or `NestedUpdateMixin`)
you should put `UniqueFieldsMixin` ahead.
"""
_unique_fields = [] # type: List[Tuple[str,UniqueValidator]]
def get_fields(self):
self._unique_fields = []
fields = super(UniqueFieldsMixin, self).get_fields()
for field_name, field in fields.items():
unique_validators = [validator
for validator in field.validators
if isinstance(validator, UniqueValidator)]
if unique_validators:
# 0 means only take the first one UniqueValidator
self._unique_fields.append((field_name, unique_validators[0]))
field.validators = [
validator for validator in field.validators
if not isinstance(validator, UniqueValidator)]
return fields
def _validate_unique_fields(self, validated_data):
for unique_field in self._unique_fields:
field_name, unique_validator = unique_field
if self.partial and field_name not in validated_data:
continue
try:
# `set_context` removed on DRF >= 3.11, pass in via __call__ instead
if hasattr(unique_validator, 'set_context'):
unique_validator.set_context(self.fields[field_name])
unique_validator(validated_data[field_name])
else:
unique_validator(validated_data[field_name],
self.fields[field_name])
except ValidationError as exc:
raise ValidationError({field_name: exc.detail})
def create(self, validated_data):
self._validate_unique_fields(validated_data)
return super(UniqueFieldsMixin, self).create(validated_data)
def update(self, instance, validated_data):
self._validate_unique_fields(validated_data)
return super(UniqueFieldsMixin, self).update(instance, validated_data)