adds sample config and fixes some linting issues

Author: bb-Ricardo

module/netbox/object_classes.py

@@ -377,15 +377,15 @@ def to_dict(self):
                     if isinstance(data_value, list):
                         new_data_value = list()
                         for possible_option in data_value:
-                            if type(possible_option) == type:
+                            if type(possible_option) is type:
                                 new_data_value.append(str(possible_option))
                             else:
                                 new_data_value.append(possible_option)
 
                         data_value = new_data_value
 
                     # if value is class name then print class name
-                    if type(data_value) == type:
+                    if type(data_value) is type:
                         data_value = str(data_value)
 
                     data_model[data_key] = data_value
@@ -458,7 +458,7 @@ def format_slug(text=None, max_len=50):
         # Enforce max length
         return text[0:max_len]
 
-    def get_uniq_slug(self, text=None, max_len=50)-> str:
+    def get_uniq_slug(self, text=None, max_len=50) -> str:
         """
         return an uniq slug. If the default slug is already used try to
         append a number until a slug is found which has not been used.
@@ -480,7 +480,7 @@ def get_uniq_slug(self, text=None, max_len=50)-> str:
         if self.inventory.slug_used(self.__class__, slug) is False:
             return slug
 
-        for x in range(1,20):
+        for x in range(1, 20):
             new_slug = f"{slug}-{x}"
             if self.inventory.slug_used(self.__class__, new_slug) is False and len(new_slug) <= max_len:
                 log.info(f"Slug '{slug}' for {self.name} '{text}' has been used. "
@@ -1272,6 +1272,7 @@ def get_site_name(self, data=None):
             if isinstance(this_site, dict):
                 return this_site.get("name")
 
+
 class NBObjectList(list):
     """
     Base class of listed NetBox objects. Extends list(). Currently used for tags and untagged VLANs
@@ -1697,7 +1698,6 @@ def update(self, data=None, read_from_netbox=False, source=None):
 
         super().update(data=data, read_from_netbox=read_from_netbox, source=source)
 
-
     def resolve_relations(self):
 
         self.resolve_scoped_relations("scope_id", "scope_type")
@@ -2141,18 +2141,6 @@ def update(self, data=None, read_from_netbox=False, source=None):
         object_type = data.get("assigned_object_type")
         assigned_object = data.get("assigned_object_id")
 
-        # Skip IP assignments when the IP is assigned to FHRP groups when config option
-        # skip_fhrp_group_ips is set to True, or if the IP is manually assigned to an FHRP group (no source)
-        if source is not None:
-            if source.source_type == "vmware":
-                config_relation = source.get_object_relation(assigned_object, "skip_fhrp_group_ips")
-                if config_relation == True and object_type == "ipam.fhrpgroup":
-                    log.debug(f"IP address with id '{assigned_object}' assigned to FHRP group. Skipping.")
-                    return
-        elif object_type == "ipam.fhrpgroup":
-            log.debug(f"IP address with id '{assigned_object}' assigned to FHRP group. It was manually created. Skipping.")
-            return
-
         # used to track changes in object primary IP assignments
         previous_ip_device_vm = None
         is_primary_ipv4_of_previous_device = False
@@ -2241,6 +2229,7 @@ def remove_interface_association(self):
         if o_type is not None:
             self.unset_attribute("assigned_object_type")
 
+
 class NBMACAddress(NetBoxObject):
     name = "MAC address"
     api_path = "dcim/mac-addresses"

settings-example.ini

@@ -298,6 +298,10 @@ password = super-secret
 ; VMs from fail-over site to NetBox.
 ;skip_srm_placeholder_vms = False
 
+; If an IP address is assigned to a FHRP group (like HSRP, VRRP, GLBP) then this IP
+; address will be skipped and not synced to NetBox to prevent incorrect syncing.
+;skip_fhrp_group_ips = False
+
 ; strip domain part from host name before syncing device to NetBox
 ;strip_host_domain_name = False
 
@@ -454,6 +458,11 @@ inventory_file_path = /full/path/to/inventory/files
 ; check_redfish if False only data which is not preset in NetBox will be added
 ;overwrite_interface_attributes = False
 
+; define if an IP address assigned to a FHRP group (like HSRP, VRRP, GLBP) will be
+; skipped. If True this IP address will be skipped and not synced to NetBox to prevent
+; incorrect syncing.
+;skip_fhrp_group_ips = False
+
 ; define in which order the IP address tenant will be assigned if tenant is undefined.
 ; possible values:
 ;   * device : host or VM tenant will be assigned to the IP address