Address comments, added overload for property with cardinality and map

Author: xiazcy

gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs

@@ -1801,6 +1801,30 @@ public GraphTraversal<TStart, TEnd> Property (IDictionary<object, object> map)
             return Wrap<TStart, TEnd>(this);
         }
 
+        /// <summary>
+        ///     Adds the property step to this <see cref="GraphTraversal{SType, EType}" />.
+        ///     When a <see cref="IDictionary{TKey, TValue}" /> is supplied, each key/value pair in the map
+        ///     will be added as a property with the given <see cref="Cardinality" />.
+        ///     A value may be a <see cref="CardinalityValue" /> to override the cardinality for that entry.
+        /// </summary>
+        public GraphTraversal<TStart, TEnd> Property(Cardinality cardinality, IDictionary<object, object> map)
+        {
+            if (map == null) throw new ArgumentNullException(nameof(map));
+
+            foreach (var entry in map)
+            {
+                if (entry.Value is CardinalityValue cardVal)
+                {
+                    Property(cardVal.Cardinality!, entry.Key, cardVal.Value);
+                }
+                else
+                {
+                    Property(cardinality, entry.Key, entry.Value);
+                }
+            }
+            return Wrap<TStart, TEnd>(this);
+        }
+
 
         /// <summary>
         ///     Adds the propertyMap step to this <see cref="GraphTraversal{SType, EType}" />.

gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversalSource.cs

@@ -75,8 +75,8 @@ public GraphTraversalSource(ICollection<ITraversalStrategy> traversalStrategies,
             GremlinLang = gremlinLang;
         }
 
-        public GraphTraversalSource(ICollection<ITraversalStrategy> traversalStrategies,
-            GremlinLang gremlinLang, IRemoteConnection connection)
+        public GraphTraversalSource(ICollection<ITraversalStrategy> traversalStrategies, GremlinLang gremlinLang,
+            IRemoteConnection connection)
             : this(traversalStrategies.Where(strategy => strategy.GetType() != typeof(RemoteStrategy)).ToList(),
                 gremlinLang)
         {

gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GremlinLang.cs

@@ -180,6 +180,8 @@ private string ArgAsString(object? arg)
 
             if (arg is byte byteVal)
                 return $"{byteVal}B";
+            if (arg is sbyte sbyteVal)
+                return $"{sbyteVal}B";
             if (arg is short shortVal)
                 return $"{shortVal}S";
             if (arg is int intVal)

…odeGeneration/BytecodeGenerationTests.cs …Generation/GremlinLangGenerationTests.csgremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/BytecodeGeneration/BytecodeGenerationTests.cs renamed to gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/GremlinLangGeneration/GremlinLangGenerationTests.cs gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/BytecodeGeneration/BytecodeGenerationTests.cs renamed to gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/GremlinLangGeneration/GremlinLangGenerationTests.cs

@@ -25,9 +25,9 @@
 using Gremlin.Net.Process.Traversal;
 using Xunit;
 
-namespace Gremlin.Net.IntegrationTest.Process.Traversal.BytecodeGeneration
+namespace Gremlin.Net.IntegrationTest.Process.Traversal.GremlinLangGeneration
 {
-    public class BytecodeGenerationTests
+    public class GremlinLangGenerationTests
     {
         [Fact]
         public void GraphTraversalStepsShouldUnrollParamsParameters()

…al/BytecodeGeneration/StrategiesTests.cs …GremlinLangGeneration/StrategiesTests.csgremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/BytecodeGeneration/StrategiesTests.cs renamed to gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/GremlinLangGeneration/StrategiesTests.cs gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/BytecodeGeneration/StrategiesTests.cs renamed to gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/GremlinLangGeneration/StrategiesTests.cs

@@ -28,7 +28,7 @@
 using Gremlin.Net.Process.Traversal.Strategy.Verification;
 using Xunit;
 
-namespace Gremlin.Net.IntegrationTest.Process.Traversal.BytecodeGeneration
+namespace Gremlin.Net.IntegrationTest.Process.Traversal.GremlinLangGeneration
 {
     public class StrategiesTests
     {

gremlin-dotnet/test/Gremlin.Net.UnitTest/Process/Traversal/GremlinLangTests.cs

@@ -1012,5 +1012,34 @@ public void GValue_reuse_same_instance()
             Assert.Equal("g.inject(ids).V(ids)", result.GetGremlin());
             Assert.True(result.Parameters.ContainsKey("ids"));
         }
+
+        // --- Cardinality with Map Tests ---
+
+        [Fact]
+        public void g_V_1_Property_List_Map_With_CardinalityValue()
+        {
+            var map = new Dictionary<object, object>
+            {
+                { "age", CardinalityValue.Single(36) },
+                { "city", "wilmington" },
+                { "state", "delaware" }
+            };
+            Assert.Equal(
+                "g.V(\"1\").property(Cardinality.single,\"age\",36).property(Cardinality.list,\"city\",\"wilmington\").property(Cardinality.list,\"state\",\"delaware\")",
+                _g.V("1").Property(Cardinality.List, map).GremlinLang.GetGremlin());
+        }
+
+        [Fact]
+        public void g_V_1_Property_Set_Map_All_Same_Cardinality()
+        {
+            var map = new Dictionary<object, object>
+            {
+                { "city", "wilmington" },
+                { "state", "delaware" }
+            };
+            Assert.Equal(
+                "g.V(\"1\").property(Cardinality.set,\"city\",\"wilmington\").property(Cardinality.set,\"state\",\"delaware\")",
+                _g.V("1").Property(Cardinality.Set, map).GremlinLang.GetGremlin());
+        }
     }
 }