fix: filter out datasets with inconsistent database and LakeFS records#5171
Open
xuang7 wants to merge 2 commits into
Open
fix: filter out datasets with inconsistent database and LakeFS records#5171xuang7 wants to merge 2 commits into
xuang7 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5171 +/- ##
============================================
- Coverage 43.66% 43.66% -0.01%
Complexity 2218 2218
============================================
Files 1049 1049
Lines 40580 40585 +5
Branches 4324 4324
============================================
+ Hits 17719 17720 +1
- Misses 21766 21768 +2
- Partials 1095 1097 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes an issue where dataset listings fail when dataset records in the database and LakeFS repositories are inconsistent. This breaks the workflow dataset picker and can also affect Hub dataset listings. The fix updates the dataset listing endpoints to first fetch existing LakeFS repository names and filter out dataset records whose repositories are missing, so valid datasets can still be returned normally.
Demo:
Any related issues, documentation, discussions?
Closes #5106
How was this PR tested?
Added two tests.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7