refactor: Drop /dashboard prefix from user-facing URLs by Ma77Ball · Pull Request #5151 · apache/texera

Ma77Ball · 2026-05-22T09:43:37Z

What changes were proposed in this PR?

Shortens user-facing URLs by dropping the /dashboard segment: /dashboard/user/workflow/2358 becomes /user/workflow/2358.
Mounts DashboardComponent at path: "" instead of "dashboard" and sets DASHBOARD = "" so all derived route constants automatically shed the prefix.
Removes a dead top-level WorkspaceComponent root route whose guard always redirected; WorkspaceComponent stays reachable via /user/workflow/:id.
Updates three hardcoded /dashboard/... references (admin execution link, share-access message, navbar-hiding regex) and the Scala email-link path.

Any related issues, documentation, or discussions?

Closes: #4407

How was this PR tested?

Ran yarn format:fix (clean, 501 files unchanged).
Ran sbt scalafmtAll (clean).
Ran tsc --noEmit (no type errors).
Updated dashboard.component.spec.ts mock router URL to match new paths.
Manually verified that routing constants resolve to the expected shortened paths.

Before

After

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.7 in compliance with ASF

Ma77Ball · 2026-05-22T09:55:26Z

@chenlica please assign a reviewer

codecov-commenter · 2026-05-22T10:16:25Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.61%. Comparing base (0f5f791) to head (ba62ea6).

Files with missing lines	Patch %	Lines
...che/texera/web/service/WorkflowEmailNotifier.scala	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5151      +/-   ##
============================================
- Coverage     43.66%   43.61%   -0.06%     
+ Complexity     2218     2215       -3     
============================================
  Files          1049     1049              
  Lines         40580    40483      -97     
  Branches       4324     4318       -6     
============================================
- Hits          17719    17656      -63     
+ Misses        21766    21729      -37     
- Partials       1095     1098       +3

Flag	Coverage Δ		*Carryforward flag
access-control-service	`39.53% <ø> (ø)`		Carriedforward from 0f5f791
agent-service	`33.76% <ø> (ø)`		Carriedforward from 0f5f791
amber	`43.92% <0.00%> (-0.03%)`	⬇️
computing-unit-managing-service	`1.38% <ø> (ø)`		Carriedforward from 0f5f791
config-service	`19.35% <ø> (ø)`		Carriedforward from 0f5f791
file-service	`32.18% <ø> (ø)`		Carriedforward from 0f5f791
frontend	`35.00% <ø> (-0.16%)`	⬇️	Carriedforward from 0f5f791
python	`90.50% <ø> (ø)`		Carriedforward from 0f5f791
workflow-compiling-service	`58.39% <ø> (ø)`		Carriedforward from 0f5f791

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Yicong-Huang · 2026-05-22T16:59:45Z

as this is user-facing, please include screenshot (of url difference).

Yicong-Huang · 2026-05-22T17:00:14Z

please also make sure PR description fits our template, and fill the coverage. thanks

Yicong-Huang

Found issues in PR template, coverage and some unrelated changes. Please review the PR once before you send it out for review.

Let's make sure authors to be the first reviewers of their PRs.

cc @chenlica @aglinxinyuan

Ma77Ball · 2026-05-22T17:06:51Z

Yes, some of my PRs are corrupted. Please hold out on review. I noticed them, but I am trying to fix them. The reason is that I am the only one editing the comment commands in our GitHub workflow, so my main has gotten out of sync with the Apache main.

Yicong-Huang · 2026-05-22T17:44:12Z

Yes, some of my PRs are corrupted. Please hold out on review. I noticed them, but I am trying to fix them. The reason is that I am the only one editing the comment commands in our GitHub workflow, so my main has gotten out of sync with the Apache main.

Please mark PRs that are not ready for review as draft. Otherwise, we assume the PR is ready for review.

…or/shortenURL

Ma77Ball · 2026-05-23T21:19:45Z

@Yicong-Huang, I added test coverage for existing spec files. I'll add the spec files for the untested hub and dashboard components in a separate pr. Please refer to this issue: #5167

… dashboard from URL.

Ma77Ball · 2026-05-23T21:31:58Z

@Yicong-Huang, also, I have finished making changes. Please review again and I apologize for the prior issue.

Yicong-Huang

LGTM. left some inline comments please take care of them.

Yicong-Huang · 2026-05-23T21:40:24Z

+    it("routes projects to the user project page", () => {
+      component.entry = { id: 200, type: "project", ...baseStats } as unknown as DashboardEntry;
+      component.initializeEntry();
+      expect(component.entryLink).toEqual([USER_PROJECT, "200"]);
+    });


do we still route projects?
cc @mengw15 @carloea2

Looking into this, I see that projects are still routed in routing.module.ts

path: "user", canActivate: [AuthGuardService], children: [ { path: "project", component: UserProjectComponent, }, { path: "project/:pid", component: UserProjectSectionComponent, },

let's raise a separate issue to discuss what to do with projects.

Yicong-Huang · 2026-05-23T21:45:40Z

 routes.push({
-  path: "dashboard",
+  path: "",
  component: DashboardComponent,


do we have plan to rename this component?

Not to my knowledge

Yicong-Huang · 2026-05-23T21:46:12Z

-// default route renders the workspace editor directly; if userSystem is enabled at runtime,
-// AppComponent will navigate to DASHBOARD_ABOUT instead.
-routes.push({
-  path: "",
-  component: WorkspaceComponent,
-  canActivate: [rootRedirectGuard],
-});
-


this seems unintended change. can we move it out from this PR?

please make sure to update PR description after this.

… dashboard from URL.

Added default route to render WorkspaceComponent with guard. Signed-off-by: Matthew B. <mgball@uci.edu>

github-actions Bot added engine refactor Refactor the code frontend Changes related to the frontend GUI labels May 22, 2026

github-actions Bot assigned Ma77Ball May 22, 2026

Yicong-Huang reviewed May 22, 2026

View reviewed changes

Comment thread amber/src/test/scala/org/apache/texera/amber/engine/faulttolerance/CheckpointSpec.scala

Yicong-Huang reviewed May 22, 2026

View reviewed changes

Comment thread frontend/src/app/app-routing.constant.ts Outdated

Yicong-Huang reviewed May 22, 2026

View reviewed changes

Comment thread frontend/src/app/app-routing.constant.ts Outdated

Yicong-Huang requested changes May 22, 2026

View reviewed changes

Ma77Ball changed the title ~~refactor: Drop /dashboard prefix from user-facing URLs~~ draft: Drop /dashboard prefix from user-facing URLs May 22, 2026

drop /dashboard prefix from user-facing URLs

652269d

Ma77Ball force-pushed the refactor/shortenURL branch from dbad080 to 652269d Compare May 23, 2026 10:45

Ma77Ball changed the title ~~draft: Drop /dashboard prefix from user-facing URLs~~ refactor: Drop /dashboard prefix from user-facing URLs May 23, 2026

Merge branch 'main' into refactor/shortenURL

0d1407c

Ma77Ball requested a review from Yicong-Huang May 23, 2026 10:49

Ma77Ball added 4 commits May 23, 2026 03:52

drop DASHBOARD prefix from route constants

4d8932a

Merge remote-tracking branch 'origin/refactor/shortenURL' into refact…

ff016e3

…or/shortenURL

lint

de7661c

Added isNavbarEnabled test

ddb9afe

Added test cases for covered components related to the pr of removing…

6c1f069

… dashboard from URL.

Yicong-Huang approved these changes May 23, 2026

View reviewed changes

Ma77Ball added 2 commits May 23, 2026 14:50

Added test cases for covered components related to the pr of removing…

52600ea

… dashboard from URL.

moved ABOUT / STRING constants up

c9495b9

Ma77Ball added 2 commits May 23, 2026 19:05

Add default route for WorkspaceComponent

7d34e89

Added default route to render WorkspaceComponent with guard. Signed-off-by: Matthew B. <mgball@uci.edu>

merge main into refactor/shortenURL

ba62ea6

Conversation

Ma77Ball commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this PR?

Any related issues, documentation, or discussions?

How was this PR tested?

Before

After

Was this PR authored or co-authored using generative AI tooling?

Uh oh!

Ma77Ball commented May 22, 2026

Uh oh!

codecov-commenter commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Yicong-Huang commented May 22, 2026

Uh oh!

Yicong-Huang commented May 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yicong-Huang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ma77Ball commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yicong-Huang commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ma77Ball commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ma77Ball commented May 23, 2026

Uh oh!

Yicong-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

Yicong-Huang May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Ma77Ball May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yicong-Huang May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Yicong-Huang May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Ma77Ball May 24, 2026

Choose a reason for hiding this comment

Uh oh!

Yicong-Huang May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Yicong-Huang May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Ma77Ball May 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ma77Ball commented May 22, 2026 •

edited

Loading

codecov-commenter commented May 22, 2026 •

edited

Loading

Yicong-Huang left a comment •

edited

Loading

Ma77Ball commented May 22, 2026 •

edited

Loading

Yicong-Huang commented May 22, 2026 •

edited

Loading

Ma77Ball commented May 23, 2026 •

edited

Loading

Ma77Ball May 23, 2026 •

edited

Loading