[feat](routine-load) Support SHOW ROUTINE LOAD TASK FOR <job_name> sy…#64151
Open
re20052 wants to merge 1 commit into
Open
[feat](routine-load) Support SHOW ROUTINE LOAD TASK FOR <job_name> sy…#64151re20052 wants to merge 1 commit into
re20052 wants to merge 1 commit into
Conversation
re20052
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Author
|
/review |
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29092 ms |
Contributor
TPC-DS: Total hot run time: 169588 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal and tests: The PR adds
SHOW ROUTINE LOAD TASK FOR [db.]job_nameand the implementation reaches the sameRoutineLoadManager.getJob(db, job)execution path as the existingWHERE JobName = ...syntax. The regression test covers current-db,FROM,IN,FOR job, andFOR db.jobforms. - Scope and clarity: The change is small and focused on parser routing plus the command constructor/validation path.
- Concurrency and lifecycle: No new shared mutable state, threads, locks, or lifecycle-sensitive objects are introduced. Existing routine-load metadata access and privilege checks are reused.
- Configuration and compatibility: No new config, storage format, FE-BE protocol, or persistence changes are introduced.
- Parallel code paths: The new syntax is consistent with the existing
SHOW ROUTINE LOAD FORlabel parsing style and reuses the existing task display path after resolving db/job. - Conditional checks and errors: The new multipart label length check rejects unsupported catalog-style names before command construction; existing database fallback and job-not-found handling remain in place.
- Test coverage/results: Regression coverage was added for the newly supported syntax. I did not run the tests in this review runner.
- Observability: No new long-running path or distributed operation is introduced, so additional logs/metrics are not required.
- Transactions/data correctness: The change is read-only show-command syntax; it does not alter transaction, visibility, delete bitmap, write, or persistence behavior.
- Performance: No material performance concern; the new path avoids expression validation and directly sets the job name.
User focus: No additional user-provided review focus was present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The current
SHOW ROUTINE LOAD TASKstatement only accepts aWHERE-based syntax to specify the job:This is inconsistent with other routine-load related statements, which all use the shorter
FORform, e.g.SHOW ROUTINE LOAD FOR <job>,STOP ROUTINE LOAD FOR <job>,PAUSE ROUTINE LOAD FOR <job>,RESUME ROUTINE LOAD FOR <job>. TheWHERE JobName = "xxx"form is verbose and rarely seen in load-related grammar.This PR adds the
FORclause toSHOW ROUTINE LOAD TASKto align with the rest of the routine-load syntax:The original
WHERE-based syntax is fully preserved for backward compatibility.Release note
Support
SHOW ROUTINE LOAD TASK FOR <job_name>syntax.Check List (For Author)
Test
Behavior changed:
FORclause toSHOW ROUTINE LOAD TASK. The originalWHERE-based syntax is preserved.