Skip to content

[fix](stream_load) Fix stream load IPv6 host parsing #64147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
re20052 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −13
Open

[fix](stream_load) Fix stream load IPv6 host parsing #64147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import org.apache.doris.thrift.TNetworkAddress;

import com.google.common.base.Strings;
import com.google.common.net.HostAndPort;
import io.netty.handler.codec.http.HttpHeaderNames;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
Expand Down Expand Up @@ -504,14 +505,11 @@ private TNetworkAddress selectEndpointByRedirectPolicy(HttpServletRequest req, B
}

String reqHost = "";
String[] pair = reqHostStr.split(":");
if (pair.length == 1) {
reqHost = pair[0];
} else if (pair.length == 2) {
reqHost = pair[0];
} else {
try {
reqHost = HostAndPort.fromString(reqHostStr).getHost();
} catch (IllegalArgumentException e) {
LOG.info("Invalid header host: {}", reqHostStr);
throw new LoadException("Invalid header host: " + reqHost);
throw new LoadException("Invalid header host: " + reqHostStr);
}

// User specified redirect policy
Expand Down Expand Up @@ -579,19 +577,26 @@ private Pair<String, Integer> splitHostAndPort(String hostPort) throws AnalysisE
throw new AnalysisException("empty endpoint: " + hostPort);
}

String[] pair = hostPort.split(":");
if (pair.length != 2) {
String host;
int port;
try {
HostAndPort hp = HostAndPort.fromString(hostPort);
if (!hp.hasPort()) {
throw new IllegalArgumentException("No port found");
}
host = hp.getHost();
port = hp.getPort();
} catch (IllegalArgumentException e) {
LOG.info("Invalid endpoint: {}", hostPort);
throw new AnalysisException("Invalid endpoint: " + hostPort);
}

int port = Integer.parseInt(pair[1]);
if (port <= 0 || port >= 65536) {
LOG.info("Invalid endpoint port: {}", pair[1]);
throw new AnalysisException("Invalid endpoint port: " + pair[1]);
LOG.info("Invalid endpoint port: {}", port);
throw new AnalysisException("Invalid endpoint port: " + port);
}

return Pair.of(pair[0], port);
return Pair.of(host, port);
}

// NOTE: This function can only be used for AuditlogPlugin stream load for now.
Expand Down
Loading