From b23f31a36df84c3884e372d9ee7676ffff4a3d81 Mon Sep 17 00:00:00 2001 From: osipovartem Date: Sat, 12 Sep 2026 23:21:04 +0300 Subject: [PATCH 1/2] Snowflake: parse ORDER BY ALL --- src/dialect/snowflake.rs | 5 +++++ tests/sqlparser_snowflake.rs | 13 +++++++++++++ 2 files changed, 18 insertions(+) diff --git a/src/dialect/snowflake.rs b/src/dialect/snowflake.rs index ce9ccfb02..eff1e2f31 100644 --- a/src/dialect/snowflake.rs +++ b/src/dialect/snowflake.rs @@ -153,6 +153,11 @@ impl Dialect for SnowflakeDialect { true } + /// See + fn supports_order_by_all(&self) -> bool { + true + } + // Snowflake supports double-dot notation when the schema name is not specified // In this case the default PUBLIC schema is used // diff --git a/tests/sqlparser_snowflake.rs b/tests/sqlparser_snowflake.rs index ab6e24254..6202881ef 100644 --- a/tests/sqlparser_snowflake.rs +++ b/tests/sqlparser_snowflake.rs @@ -44,6 +44,19 @@ fn test_snowflake_create_table() { } } +#[test] +fn parse_order_by_all() { + let query = snowflake() + .verified_query("SELECT value + 1 AS computed FROM source ORDER BY ALL DESC NULLS FIRST"); + assert_eq!( + query.order_by.expect("ORDER BY expected").kind, + OrderByKind::All(OrderByOptions { + sort: Some(OrderBySort::Desc), + nulls_first: Some(true), + }) + ); +} + #[test] fn parse_sf_create_secure_view_and_materialized_view() { for sql in [ From e3680cebfa90af4ee19a5e86f436d5a3d606b362 Mon Sep 17 00:00:00 2001 From: osipovartem Date: Thu, 24 Sep 2026 17:05:25 +0300 Subject: [PATCH 2/2] Drop redundant Snowflake ORDER BY ALL test --- tests/sqlparser_snowflake.rs | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/tests/sqlparser_snowflake.rs b/tests/sqlparser_snowflake.rs index 6202881ef..ab6e24254 100644 --- a/tests/sqlparser_snowflake.rs +++ b/tests/sqlparser_snowflake.rs @@ -44,19 +44,6 @@ fn test_snowflake_create_table() { } } -#[test] -fn parse_order_by_all() { - let query = snowflake() - .verified_query("SELECT value + 1 AS computed FROM source ORDER BY ALL DESC NULLS FIRST"); - assert_eq!( - query.order_by.expect("ORDER BY expected").kind, - OrderByKind::All(OrderByOptions { - sort: Some(OrderBySort::Desc), - nulls_first: Some(true), - }) - ); -} - #[test] fn parse_sf_create_secure_view_and_materialized_view() { for sql in [